Conversation
JulianGro
force-pushed
the
RelWithDebInfo
branch
2 times, most recently
from
July 17, 2026 19:29
4fecacf to
542027d
Compare
JulianGro
marked this pull request as ready for review
July 17, 2026 20:08
JulianGro
marked this pull request as draft
July 22, 2026 13:57
JulianGro
force-pushed
the
RelWithDebInfo
branch
2 times, most recently
from
August 3, 2026 10:26
c73dcf6 to
5244e15
Compare
JulianGro
force-pushed
the
RelWithDebInfo
branch
from
August 10, 2026 15:55
270da3a to
c3c2cb9
Compare
Draft
JulianGro
force-pushed
the
RelWithDebInfo
branch
from
August 28, 2026 10:00
aceb08e to
4dcd37b
Compare
Member
Author
|
@vatral can we change some of Sentry-Native's behaviour? Then there are quite a lot of log messages coming from Sentry. I feel like it is too chatty. |
Works, but still needs settings, more data, a bit of refactoring, etc
This is the start of a plan to refactor the API to better fit the features Sentry Native exposes. If we want to bring back Crashpad and Breakpad later, they should be adapted to the new API. It appears that we can also do cleaner exception handling based on the API docs, so that's removed here as well.
Add log streaming and stats submission
Generates a random but easily pronounceable tag that can be used to pass to a developer, to let them easily locate a matching report in the Sentry (or similar) database.
Avoid discarding reports
Since the current version of Sentry Native is too old, contexts have to be manually merged. This could be removed after an upgrade
Make it correctly persist. There was a bit of a snag between the menu system and the crash specific setting. Make it all use the same setting keys.
We've discussed redoing the menu system, so this is probably better addressed at that point in time or at least as a separate PR.
Also remove old unused code
Add support tag to about screen
… which is of non-class type 'const char [26]'"
JulianGro
force-pushed
the
RelWithDebInfo
branch
from
August 31, 2026 17:12
1ad853b to
9836d75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea behind this PR is to bring back crash reporting, but in a way that yields actually useful crash reports.
In the past, we would collect crash reports, but without debug information and with the builds fully optimized. This would essentially only tell us that someone was crashing.
Now I want to create RelWithDebInfo builds, automatically upload the debug information to Sentry, and strip the debug symbols in the later packaging step.
With Dale's changes, this also switches us from using Crashpad directly to using Sentry-native which takes the maintenance burden of trying to build Google software away.
Conan recipe change: overte-org/overte-conan-recipes#59
I tested the Sentry uploading locally using
act, since Pull Requests cannot usually access secrets.The size difference between Release and RelWithDebInfo/Debug builds stems from Qt. Apparently, when building from source, the libraries Qt depends on are statically linked.