Skip to content

songmaker pins logline v0.7.0, tandem v0.9.1 and agents v0.57.0; job and scorer lines follow the standard - #3282

Open
FlexOr2 wants to merge 8 commits into
mainfrom
claude/issue-3276-songmaker-pins-logline-v0-7-0-and-keeps
Open

FlexOr2 wants to merge 8 commits into
mainfrom
claude/issue-3276-songmaker-pins-logline-v0-7-0-and-keeps

Conversation

@FlexOr2

@FlexOr2 FlexOr2 commented Nov 18, 2026

Copy link
Copy Markdown
Member

Work-Item: #3276

Closes #3276
Closes #3275

What changes

  • Pins: logline v0.7.0, tandem v0.9.1, agents v0.57.0 (both lines each); uv.lock regenerated. The release notes name no host change for songmaker: it implements no PlaceStore and uses no WakeChannel, so agents.mcp_server and lifecycle.py need nothing.
  • Denied log fields: an AST scan of every log.* call in src finds no call that passes a user_id, _seconds or other deny-list field (fields enter only through StepTimer: job_function, job_id), so nothing is renamed. The messages that name a user id in text are not fields and stay.
  • arq_job.ended follows the job's result: logged_job takes status_of, the job's row status once it returned; failed ends the line failed (reason job_failed), cancelled ends it cancelled.
  • The scorer child process configures logline (SCORING_SERVICE_NAME), so a scorer failure is one JSON line with the traceback under exception, and an uncaught crash of the process is one process.crashed line. Proven in real processes.
  • docs/architecture.md: the logline paragraph names arq_job.ended, the trace in job kwargs, the request line's sub, the scorer child and the dropped fields.

AGENT__BACKEND stays

agents v0.57.0 still reads AgentConfig.backend (a required field of agents.config.AgentConfig), so AGENT__BACKEND stays in docker/docker-compose.test.yml, settings.py and docs/security.md; it leaves with the agents release that deletes it (agents#1010).

Verification

  • scripts/test_postgresql.sh on the worker, arq, scoring, mcp_server, agent, server, settings and lifecycle test modules: 875 passed.
  • bash scripts/static_checks.sh: exit 0.
  • Tests for the job line and the scorer child were written after the code.

🤖 Generated with Claude Code

FlexOr2 and others added 8 commits November 18, 2026 01:09
logline v0.7.0 needs tandem >=0.9.1 and agents >=0.57.0 to widen their ranges.
No wake or PlaceStore code lives in the host, so no host change follows.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A job records its failure in its row and returns, so the line read ok for
failed and cancelled jobs. logged_job takes the row's status and ends the
line failed or cancelled to match.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A spawned process starts without its parent's logging setup, so a scorer
failure reached stderr as plain multi-line text. The child configures
logline under the scoring worker's service name before it serves.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…gline's dropped fields

A crash of a scorer process is one JSON line, proven in a real process.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The mocked-session test patched get_job at its import location; the rows of a
PostgreSQL database prove the same decider without a patch.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Deleting status_of from any of the five registrations turned no test red; one
test per registered function now runs it against a real failed job row.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

songmaker pins logline v0.7.0 and keeps every field it logs songmaker pins agents v0.57.0 and sets no AGENT__BACKEND

1 participant