Repository navigation
Conversation
…ules A German catalog beside the English source makes de a language the app offers: the server's resolver answers de for a browser that asks for it, <html lang> carries it, and the root layout loads the German words. Every msgstr is a model translation of the en source (informal du, plural families whole, named gaps kept). design v0.33.1 declares a further language by its catalog file alone, so pyproject.toml stays unchanged. Work item #3278. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With de a language the words module offers, the page-language tests no longer need to patch the offered languages, and the sign-out page test proves the German label for a browser that asks for de beside the English default. Work item #3278. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pass LANG-7 makes a further language cost one render pass per surface. The pass is a Playwright spec the E2E legs run on their existing stack: each surface opens with the browser asking for de, at 390 px and 1280 px, and fails on a wrong <html lang>, a catalog key or unrendered value shown, or a text wider than its box. quality's render-pass rule needs a job a tracked workflow names and the gate makes mandatory; a reusable workflow's job is listed without its caller's prefix, so no E2E job can be both. The Render pass job in ci.yml is green only when the E2E run passed and the spec lists tests in both projects. Rejected: a second stack boot for a job of its own, which doubles the E2E cost. Work item #3278. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sign-in, no access, settings index, error page, take page and Now Playing included The pass named full coverage while skipping six surfaces. The seed now shares a song and a take, the signed-out pages open without a session, and words.py's size reason names both catalogs it is generated from. seed-shares.ts keeps the share seeding out of seed.ts, which sits at its size ceiling. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e in German The pass listed every page route but (library)/playlist/[slug] and auth/callback; a per-attempt playlist is opened by its slug and the callback is opened signed out with an issuer error, which answers 403 as auth-flows.spec.ts drives it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
…gmaker-s-interface-speaks-german-for
…opens a song through its button and waits for the phone's Now Playing trigger The rail's nav and resize handle hang out of their boxes by design in every language, a song row is a button and not a link, and the phone keeps Now Playing's right panel shut behind a queue trigger; each made the pass fail without a missing translation. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The de words module loaded only in the browser, so no unit test reached its line in the generated loader. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nerated words directory Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The German words module added 325 uncovered lines (5 of 330 covered), which took the frontend's measured lines to 94.34 % against the 95 % floor and statements to 93.92 % against 94 %; the red Frontend job then skipped the coverage assembly, so the Sonar gate found no coverage artifact. The words are written by design-catalogs and proven by its --check, as src/songmaker_cli/words.py already is, so the vitest, Sonar and coveragerc exclusions name them too. Without them the CI lcov of run 44206821106 measures 96.46 % lines. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Work-Item: #3278
Closes #3278
What changes
frontend/src/lib/catalogs/de.po: the German catalog, created bydesign-catalogs --syncand everymsgstrwritten by the builder model from the en source (informal du, plural families one/other whole, named gaps and{#…}markers kept). design v0.33.1 declares a further language by its catalog file; it has no language key in[tool.design-catalogs], sopyproject.tomlis unchanged.frontend/src/lib/words/de.ts,index.ts(languagesen,de),src/songmaker_cli/words.py.page-words.tsalready loadedloadWords(pageLanguage())once from the root layout, so it is unchanged.request_languageandwords.text, so it now speaks German for a browser asking for de;tests/songmaker_cli/test_page_language.pydrops its patch of the offered languages and proves the German label.frontend/e2e/language-render.spec.tsruns in the existing E2E legs, opening every surface in each further language at 390 px and 1280 px. It fails when<html lang>is wrong, a catalog key or unrendered value shows, or a text is wider than its box. A newRender passjob inci.ymlis mandatory and declared as[languages] render_pass. It is green only when E2E passed and the spec lists tests in both projects.quality/config.toml:de.tsis a generated size exception, likeen.ts.Outside the claimed scope
quality/config.toml: mandatory job,[languages], generated-size entry.frontend/e2e/language-render.spec.ts,frontend/e2e/README.md: the E2E specs live infrontend/e2e, notfrontend/tests.tests/songmaker_cli/test_page_language.py: sign-out test in German.docs/testing.md: the CI job table row.Remaining risk
job_nameslists a reusable workflow's jobs without the caller prefix, soE2E / Browser suitecannot be the render-pass job. That is why there is a separate job. Reported to the head for quality.🤖 Generated with Claude Code