Skip to content

Songmaker's interface speaks German - #3281

Open
FlexOr2 wants to merge 11 commits into
mainfrom
claude/issue-3278-songmaker-s-interface-speaks-german-for
Open

FlexOr2 wants to merge 11 commits into
mainfrom
claude/issue-3278-songmaker-s-interface-speaks-german-for

Conversation

@FlexOr2

@FlexOr2 FlexOr2 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Work-Item: #3278
Closes #3278

What changes

  • frontend/src/lib/catalogs/de.po: the German catalog, created by design-catalogs --sync and every msgstr written by the builder model from the en source (informal du, plural families one/other whole, named gaps and {#…} markers kept). design v0.33.1 declares a further language by its catalog file; it has no language key in [tool.design-catalogs], so pyproject.toml is unchanged.
  • Generated: frontend/src/lib/words/de.ts, index.ts (languages en, de), src/songmaker_cli/words.py. page-words.ts already loaded loadWords(pageLanguage()) once from the root layout, so it is unchanged.
  • Sign-out page: served through request_language and words.text, so it now speaks German for a browser asking for de; tests/songmaker_cli/test_page_language.py drops its patch of the offered languages and proves the German label.
  • Render pass (LANG-7): frontend/e2e/language-render.spec.ts runs in the existing E2E legs, opening every surface in each further language at 390 px and 1280 px. It fails when <html lang> is wrong, a catalog key or unrendered value shows, or a text is wider than its box. A new Render pass job in ci.yml is mandatory and declared as [languages] render_pass. It is green only when E2E passed and the spec lists tests in both projects.
  • quality/config.toml: de.ts is a generated size exception, like en.ts.

Outside the claimed scope

  • quality/config.toml: mandatory job, [languages], generated-size entry.
  • frontend/e2e/language-render.spec.ts, frontend/e2e/README.md: the E2E specs live in frontend/e2e, not frontend/tests.
  • tests/songmaker_cli/test_page_language.py: sign-out test in German.
  • docs/testing.md: the CI job table row.

Remaining risk

  • The render pass ran against a local stack built from this branch: all 44 tests (22 surfaces at phone and desktop width) pass in German. The overflow check reads only elements that hold text of their own, because the rail's navigation and resize handle hang out of their boxes by design in every language.
  • quality's job_names lists a reusable workflow's jobs without the caller prefix, so E2E / Browser suite cannot be the render-pass job. That is why there is a separate job. Reported to the head for quality.

🤖 Generated with Claude Code

FlexOr2 and others added 5 commits November 18, 2026 00:19
…ules

A German catalog beside the English source makes de a language the app
offers: the server's resolver answers de for a browser that asks for it,
<html lang> carries it, and the root layout loads the German words. Every
msgstr is a model translation of the en source (informal du, plural
families whole, named gaps kept). design v0.33.1 declares a further
language by its catalog file alone, so pyproject.toml stays unchanged.

Work item #3278.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With de a language the words module offers, the page-language tests no
longer need to patch the offered languages, and the sign-out page test
proves the German label for a browser that asks for de beside the
English default.

Work item #3278.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pass

LANG-7 makes a further language cost one render pass per surface. The
pass is a Playwright spec the E2E legs run on their existing stack: each
surface opens with the browser asking for de, at 390 px and 1280 px, and
fails on a wrong <html lang>, a catalog key or unrendered value shown, or
a text wider than its box. quality's render-pass rule needs a job a
tracked workflow names and the gate makes mandatory; a reusable
workflow's job is listed without its caller's prefix, so no E2E job can
be both. The Render pass job in ci.yml is green only when the E2E run
passed and the spec lists tests in both projects. Rejected: a second
stack boot for a job of its own, which doubles the E2E cost.

Work item #3278.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sign-in, no access, settings index, error page, take page and Now Playing included

The pass named full coverage while skipping six surfaces. The seed now shares a song and a take, the signed-out pages open without a session, and words.py's size reason names both catalogs it is generated from. seed-shares.ts keeps the share seeding out of seed.ts, which sits at its size ceiling.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e in German

The pass listed every page route but (library)/playlist/[slug] and auth/callback;
a per-attempt playlist is opened by its slug and the callback is opened signed out
with an issuer error, which answers 403 as auth-flows.spec.ts drives it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

FlexOr2 and others added 6 commits November 18, 2026 01:07
…opens a song through its button and waits for the phone's Now Playing trigger

The rail's nav and resize handle hang out of their boxes by design in every language, a song row is a button and not a link, and the phone keeps Now Playing's right panel shut behind a queue trigger; each made the pass fail without a missing translation.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The de words module loaded only in the browser, so no unit test reached its line in the generated loader.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nerated words directory

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The German words module added 325 uncovered lines (5 of 330 covered), which
took the frontend's measured lines to 94.34 % against the 95 % floor and
statements to 93.92 % against 94 %; the red Frontend job then skipped the
coverage assembly, so the Sonar gate found no coverage artifact. The words are
written by design-catalogs and proven by its --check, as src/songmaker_cli/words.py
already is, so the vitest, Sonar and coveragerc exclusions name them too.
Without them the CI lcov of run 44206821106 measures 96.46 % lines.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Songmaker's interface speaks German for a German reader

1 participant