Repository navigation
Every arq job logs its end and runs in its enqueuer's trace; request lines carry sub - #3280
Merged
FlexOr2 merged 8 commits intoNov 18, 2026
Conversation
… outcome The jobs bound structlog context variables that logline's records never carry, so no job line named its job. The worker registration wraps each job and cron in logline's StepTimer; the dead bindings go. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
serialize_arq carries the enqueuer's traceparent in the job's keyword arguments; the job wrapper runs the job inside logline's unit_trace, which detaches when the job ends. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…wrapped method's owner The explicit cron names changed every cron job's arq id; the default derives from the wrapped method's qualname. The singleton-method pins read __self__, which the logged wrapper does not carry. The arq codec outcome test also runs a job without arguments, which logs no job id. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The title is content; the logline standard keeps content out of logs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…equest Sonar flagged the request path id and model name in the log call as log injection. The song id now comes from the loaded song and the model id from the active model row the request matched. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
FlexOr2
deleted the
claude/issue-3279-every-job-step-logs-its-end-and-an-arq-j
branch
November 18, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Work-Item: #3279
Closes #3279
Each arq job and cron is wrapped at registration: one
arq_job.endedline (StepTimer: job_function, job_id, duration_ms, outcome), run insideunit_trace.serialize_arqcarries the enqueuer's traceparent in the job kwargs.authenticate_requestcallsset_subwith the account id (the Keycloak subject). The dead structlog contextvar bindings in the jobs and workers are gone.Co-writer turn: it is an HTTP SSE request (no WebSocket), already inside its request trace, so
unit_tracedoes not fit; nothing to build.scoring/subprocess_runner.pystill binds structlog contextvars in the scorer child (not touched).Routing: build sonnet/medium; fix sonnet/high; review sonnet/high; test sonnet/medium; gate none; land haiku/low. Fix rounds: 3. Blocking: src/songmaker_cli/music_worker.py:188 → review; music_worker.py:155 → review; song-title-in-generate-log → test; src/songmaker_cli/generation_api.py:308 → ci; SonarCloud Code Analysis → ci
Follow-ups: outcome of failed/cancelled jobs, docs/architecture.md logline paragraph, scorer plain-text tracebacks, co-writer turn trace -> #3254
🤖 Generated with Claude Code