Skip to content

B1's follow-ups after B1a and B1b landed #65

Closed

Description

@FlexOr2

Reviewers and the explorative testers of lanes #55 (PR #57) and #56 (PR #67) raised these follow-ups against the images job's render and its test runner. Each is a bullet; the first two are the ones with a security reading.

  • The render image by mutable tag without --entrypoint. Where: .github/workflows/ci.yml images job (RENDER_IMAGE: ubuntu:26.04) and scripts/verify_image_release.sh render(). The image is pulled by mutable tag, and docker run passes flux build ... as the command without --entrypoint; an image that sets an ENTRYPOINT would receive those words as arguments and could print a render of its choosing. Suggested fix: pin the image by digest, or pass --entrypoint /usr/local/bin/flux. The bootstrap job's unpinned ubuntu:26.04 already exists on main, so whether this attacker is in scope is the trust model's call.
  • The render has no timeout of its own. Where: scripts/verify_image_release.sh render(); a second Kustomization with spec.path: ./clusters/pc (the root's own path) makes flux build --recursive run without end (scratch tree f6-recursive-self-path hung past 150 s, timeout exit 124, no output). In CI the job times out at 10 minutes, so the check goes red without a message naming the Kustomization. Suggested fix: a render timeout that becomes a red record naming the render.
  • Two owners decide which sources are PC-only. Where: scripts/verify_image_release.sh (PC_ONLY_SOURCE), .github/workflows/ci.yml cluster overlay patches, AGENTS.md cluster line. AGENTS.md's "a new PC-only source joins that list" names only the overlay; drift fails loud (an unmapped source makes the render red), but the list has two owners. Suggested fix: one owner for the list, or the AGENTS.md line naming both.
  • The runner does not assert the G2 log lines. Where: tests/images/run.sh. The contract's "each substituteFrom Secret is named in the log as a gap" is not asserted, since the runner compares only exit status and red set; the G2 lines were seen printed for all three Secret cases, but nothing catches a regression. Suggested fix: compare the gap lines too, or rule it out.
  • The runner's header omits RENDER_IMAGE. Where: tests/images/run.sh header. The runner exports GITHUB_* and DEFAULT_BRANCH but not RENDER_IMAGE; run as its header says (mise exec -- tests/images/run.sh) it fails every case with exit 2 "RENDER_IMAGE is not set"; only CI's job env supplies it. Suggested fix: name RENDER_IMAGE in the header or default it in the runner.
  • Unknown-kind reds print numeric field paths. Where: scripts/verify_image_release.sh judge_unknown_kinds (FIELD_PATH). They print .spec.template.spec.containers.0.image while Pod-template reds print .containers[main].image. Cosmetic; both name object, path and image. Suggested fix: one path form, or rule it out.
  • A short ref in a custom kind is unjudged. Where: the unknown-kind candidate rule. A custom kind whose field holds a Docker Hub short ref (a Widget with spec.imageName: nginx:1 or library/nginx:1) is neither red nor judged; within the contract (host-qualified only), but an unjudged way to name an image. Suggested fix: name it as a gap on Platform CI refuses every image reference that is neither an attested app release nor a listed vendor at a digest #49 or extend the candidate rule.
  • A platform-secrets url with another owner case is red. Where: the PC-only source url check. OvernightWorks/platform-secrets is red as "not the repository overnightworks/platform-secrets", although GitHub treats the owner case-insensitively; a false red in the safe direction, and the committed url is lowercase. Suggested fix: compare the owner case-insensitively, or rule it out.
  • The missing vendor list message. Where: the vendor list read in scripts/verify_image_release.sh. With the file absent the red record says "yq cannot read the vendor list" (exit 1); it does not say the file is missing. Suggested fix: test for the file and say so.
  • A kustomize component under .github/ is judged. Where: the render and the contract's source-field text. The script renders and judges such a component (red when it adds an unlisted image), while Flux's artifact excludes .github/ by default, so on the PC that layer would fail to build. The direction is safe (CI sees a superset), but the contract text does not name it. Suggested fix: name it in the contract text or in AGENTS.md, or rule it out.
  • The scratch draft PR showed two red causes. Where: the evidence for the verdict wiring. The scratch draft PR also turned the cluster job red (the root's inventory held a Deployment without a health check), so quality / verdict was red from two causes and that run alone does not show that images by itself turns the verdict red; the wiring is confirmed by quality/config.toml mandatory_jobs and the ci.yml needs list. Suggested fix: one scratch draft PR with only an images red, or rule it out.
  • An app ref in a private or non-existent owner repository is red with identical text (from B1b, B1b: the job images checks each app ref's tag, attestation and signer commit #56). Where: scripts/verify_image_release.sh resolve_tag_commit. In CI both are red with git ls-remote ... failed: fatal: could not read Username for https://github.com: terminal prompts disabled; it fails closed, but the message does not say the repository is private or absent. hopin is public, so nothing is affected today. Suggested fix: say so in the red record when a private app repository appears, or rule it out.
  • E4's other-workflow half was not driven (from B1b, B1b: the job images checks each app ref's tag, attestation and signer commit #56). Where: the attestation check in scripts/verify_image_release.sh, which passes --signer-workflow overnightworks/quality/.github/workflows/image.yml. Whether gh's SAN pattern rejects a lookalike workflow file name (such as image.yml.bak) or another workflow of quality needs a real attestation from such a workflow; none exists, so the case is judged only from the flags. Suggested fix: drive it once a lookalike or other quality workflow attests an image, or rule it out.

Done when each bullet is fixed or ruled out with its reason.

version = 1
now = "B1a landed with these follow-ups open; none changes what its job refuses today."
next = "Pull when the images job is next touched, or before a second PC-only source is added."
done_when = "Each bullet of this item is fixed in scripts/verify_image_release.sh, tests/images or .github/workflows/ci.yml, or ruled out with its reason in the item's journal."

scope = [".github/workflows/ci.yml", "AGENTS.md", "scripts/verify_image_release.sh", "tests/images"]

size = "S"

whole = "The bullets all concern the one images job and its runner, and a fix to one (the render image, its timeout, the PC-only list) changes the lines the others read."

Activity

  1. added theissue type on Nov 7, 2026
  2. changed the title [-]B1a's follow-ups after its first landing[/-] [+]B1's follow-ups after B1a and B1b landed[/+] on Nov 7, 2026
  3. FlexOr2 commented on Nov 9, 2026

    @FlexOr2
    MemberAuthor

    Lane #65, PR 247. Bullets ruled out, with the builder's reasons; the review and gate judge them:

    • Two owners of PC-only (code part): the cluster overlay in tests/flux/reconcile_the_candidate_tree.sh is a kustomize patch pair per source. It swaps the source's spec and the sibling Kustomization's sourceRef, which a name from the script cannot derive. The script also runs main when sourced. An unmapped source fails the render, so the two lists cannot drift silently. AGENTS.md now names both.
    • Numeric field paths: cosmetic. Unknown kinds have no container names, and both forms name the object, the path and the image.
    • Short ref in a custom kind: within the contract (host-qualified only). Widening the candidate rule risks false reds. This is a gap for Platform CI refuses every image reference that is neither an attested app release nor a listed vendor at a digest #49.
    • Owner case in the platform-secrets URL: a case-insensitive compare would pass a URL that is red today. The false red is in the safe direction, and the committed URL is lowercase.
    • .github/ kustomize component: the safe direction (red when it adds an unlisted image). That Flux's artifact excludes .github/ is not verified here.
    • Scratch draft PR with two red causes: this was evidence process, not code. The wiring stands in quality/config.toml mandatory_jobs and the needs list.
    • Private or absent app repository: git ls-remote prints the same text for both. The check fails closed.
    • E4's other-workflow half: it needs a real attestation from a lookalike workflow, and none exists.
  4. FlexOr2 commented on Nov 9, 2026

    @FlexOr2
    MemberAuthor

    Correction to the journal above: 6 bullets are fixed (the render image, the render timeout, the PC-only sentence in AGENTS.md, the G2 gap lines, the runner's RENDER_IMAGE, the missing vendor list) and 7 are ruled out (numeric field paths, short ref in a custom kind, owner case, the .github/ component, the scratch draft PR, private or absent app repository, E4's other half). The matrix review of PR 247 found every reason true; bullet 7's gap already stands on #49.

  5. FlexOr2 commented on Nov 9, 2026

    @FlexOr2
    MemberAuthor

    Journal, from the final gate of PR 247:

  6. FlexOr2 commented on Nov 9, 2026

    @FlexOr2
    MemberAuthor

    Landed in #247 at 3afb204.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions