Repository navigation
Closed
Copy link
Description
The mandatory job images checks the tag, attestation and signer commit of each distinct app ref of the rendered objects (#55, B1c's charts included) with the locked gh. This replaces #55's outright red.
Caller
- Platform CI refuses every image reference that is neither an attested app release nor a listed vendor at a digest #49, point 10's B1b, the last of its three pull requests: it lands with hopin's first release and holds S4 and S7; S5 of hopin's manifests (hopin runs on the platform from its attested private image, routed by Traefik #46) lands after it.
Done when
- S4 for each distinct app ref the render yields (B1a: the mandatory job images renders the tree as Flux applies it and refuses every rendered image that is neither a listed vendor at a digest nor an app ref #55 S2, B1c's HelmReleases included), the tag
v<version>in<owner>/<repo>resolves to a commit, peeled when annotated, or the job is red naming the missing tag;gh attestation verifyby digest with point 4's flags passes with that commit as--source-digest, or the job is red; every verified attestation'sbuildSignerDigestis a commit on quality's main, or the job is red naming it; - S7 against hopin's first attested release, E1 and E15 are green and E2 to E4 and E7 to E9 are red, each for its own reason; the external facts under Unknowns are settled with the locked gh and yq; the matrix below is reported;
Scenario matrix
Conventions are the intro of #55's matrix. A driven cell's app ref sits in a manifest that a Kustomization in clusters/pc reaches, since B1 judges rendered objects only. A scratch pull request is closed and its branch deleted after. A cell that needs only gh and git may run the script locally on a scratch tree with the locked tools.
E2 is held in #55's matrix; its B1b half is driven here.
| Cell | What is driven | Expected | Proven by |
|---|---|---|---|
| E1 | a completed release: hopin's first attested ref, its lightweight tag at the attested commit | images green; the log names the ref, the tag's commit and the signer digest; quality / verdict green |
driven, after the release |
| E3 | the tag at another commit: hopin's real digest with version 2026.11.06.1, whose annotated tag peels to df39828. Precondition: the release's attested commit is not df39828, shown by git ls-remote |
red from gh attestation verify's source-digest check, after gh resolved the requested digest; the log shows the peeled commit df39828, not the tag object 831fa65. A red from authentication, a 404 or a registry tag does not hold the cell |
driven, after |
| E4 | a digest no image.yml attestation names: the platform manifest inside hopin's index |
red, no attestation verified; the other-workflow case judged by reading gh's SAN pattern against --signer-workflow |
driven, after |
| E7 | the attestation names another repository: hopin's real ref with the call's --repo edited to <owner>/presentator |
red by --repo |
driven, after |
| E8 | the signer digest off quality's main: the certificate's value replaced in a script copy by PR #404's head 239e51e | red naming 239e51e as not on quality's main | driven, after |
| E9 | another predicate type: the call's --predicate-type edited to an SPDX type |
red; the script reads nothing from statement |
driven, after; read |
| E14 | E1 again without attestations: read |
green or red settles whether the grant stays; the diff keeps only what E1 needed | driven, after |
| E15 | an annotated tag at the attested commit: a script copy whose tag lookup reads a local clone of hopin carrying an annotated v<version> at the release's commit |
green; the log shows the peeled commit equal to the attested source digest | driven, after |
Files
scripts/verify_image_release.sh: the per-ref release checks over the app refs B1a: the mandatory job images renders the tree as Flux applies it and refuses every rendered image that is neither a listed vendor at a digest nor an app ref #55 collects, replacing its outright red; it calls only git, gh, flux and yq..github/workflows/ci.yml:docker loginthrough stdin.mise.toml(gh) andmise.lock(regenerated withmise lock).
Estimate: about 60 lines in three files.
Neighbours
- The previous slice is B1a: the mandatory job images renders the tree as Flux applies it and refuses every rendered image that is neither a listed vendor at a digest nor an app ref #55. The container's Neighbours hold the rest.
version = 1
now = "Cut from #49, which passed its plan review of 06.11.2026 in four rounds (Codex gpt-6-astra high and Opus 5.5 high, both APPROVE on the last delta)."
next = "Lands once E1, E3, E4, E7 to E9 and E15 hold against hopin's first attested release, before hopin's manifests (#46)."
done_when = "On pull requests and pushes to main, the mandatory job images resolves, for each distinct app ref of the rendered objects, the tag v<version> to a commit, peeled when annotated, passes gh attestation verify by digest with that commit as source digest and point 4's flags, and requires every verified attestation's buildSignerDigest to be a commit on quality's main; it grants only contents: read, packages: read and, if E14 shows it is needed, attestations: read; E1 and E15 are green against hopin's first attested release and the cells B1b holds are reported."
scope = [".github/workflows/ci.yml", "AGENTS.md", "mise.lock", "mise.toml", "scripts/verify_image_release.sh", "tests/images"]
size = "S"
whole = "The release checks, the login that lets gh read the registry and gh in the lock are one change: the checks run only through the login and the locked gh; the two fixtures that pin B1a's outright red and AGENTS.md's images sentence change with that behaviour."
Metadata
Metadata
Assignees
Labels
No labels
Activity