Skip to content

figure moves into managed, and platform's GitHub configuration is import-only again #313

Closed

Description

@FlexOr2

figure moves from created into managed, and platform's GitHub configuration is import-only again.

Caller

#312 creates overnightworks/figure through a created map that exists only until the repository does. After #312's apply, every plan of src/opentofu/github fails on #312's precondition ("a name in created that the listing holds"), so no other apply of the root runs until this lands. #312's body, "Change 2, the fold", is this item's contract.

What it builds

  • In src/opentofu/github/repositories.tf: figure joins local.managed in its sorted place; created, declared, the six attributes set only for a key of created, the precondition and the rewritten import comment go, and the comment reads again that an import of a name that does not exist fails the plan, so no repository is created.
  • In src/opentofu/github/tests/repository_listing.tftest.hcl: every fixture gains figure (public, not archived, not a fork); the run platform's GitHub configuration creates overnightworks/figure #312 added for created goes.
  • src/opentofu/github/tests/repository_creation.tftest.hcl is deleted. The mechanism stays recoverable from git at platform's GitHub configuration creates overnightworks/figure #312's commit.

Proof

  • mise run github:test is green in CI.
  • Before the pull request, the builder runs scripts/apply_github_settings.sh on the lane's commit; it must exit 0 (no change): the import blocks name figure, which the state already holds.
  • After the landing, the same plan from origin/main exits 0; it goes into this item's journal. No apply is needed.

Risk

Not material: the plan proves that nothing on GitHub or in the state changes.

Rollback: a revert brings created back, and every plan fails on its precondition again; so a revert is never the way back here, a fix forward is.

Done when

  • figure is in managed and in every listing fixture; created and its wiring are gone; CI is green.
  • The plan before the pull request and the plan after the landing both exit 0, in the journal.
version = 1
now = "Cut on 09.11.2026 with #312, which creates figure and leaves every plan failing on its precondition until this fold lands."
next = "Dispatch the moment #312's apply has run: claim, fold, plan, pull request."
done_when = "figure is in managed and every listing fixture, created and its wiring are gone, CI is green, and the plans before the pull request and after the landing both exit 0."
scope = ["src/opentofu/github/repositories.tf", "src/opentofu/github/tests/repository_listing.tftest.hcl", "src/opentofu/github/tests/repository_creation.tftest.hcl"]

Activity

  1. added theissue type on Nov 9, 2026
  2. FlexOr2 commented on Nov 9, 2026

    @FlexOr2
    MemberAuthor

    Pre-PR plan: scripts/apply_github_settings.sh (plan only) on 45e3f7f, run by the operator on 09.11.2026, exited 0 with no change (all 16 managed repositories and 16 vulnerability-alert objects refreshed, figure among them). Pull request: #347.

  3. FlexOr2 commented on Nov 9, 2026

    @FlexOr2
    MemberAuthor

    Journal, 09.11.2026: the plan after the landing. The operator ran scripts/apply_github_settings.sh (plan only) in the primary checkout at origin/main cf37ca7 (PR #347's merge): No changes. Your infrastructure matches the configuration., exit 0. Both plans of the Done when exited 0; no apply was needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions