AO3-7290 Maintain scroll position when TOS popup appears#5576
Open
marcus8448 wants to merge 3 commits intootwcode:masterfrom
Open
AO3-7290 Maintain scroll position when TOS popup appears#5576marcus8448 wants to merge 3 commits intootwcode:masterfrom
marcus8448 wants to merge 3 commits intootwcode:masterfrom
Conversation
Helper methods have some weird magic to get loaded, preventing them from being mocked easily. This seems like the least-complicated way to avoid that.
I don't think it's worth the hacks needed to get the mocks to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7290
Purpose
Modifies the Terms of Service popup to have a fixed (screen-space) position and to hide the main content without changing the page layout. This allows for the browser's scroll position to be maintained when the popup appears.
Unfortunately I couldn't come up with a nice way to automatically test scrolling, but in lieu of that I've added tests for the popup in general.
Credit
marcus8448 (he/him)