Move score multiplier fields in Mod to dedicated ScoreMultiplierCalculator classes#650
Open
Rian8337 wants to merge 23 commits into
Open
Move score multiplier fields in Mod to dedicated ScoreMultiplierCalculator classes#650Rian8337 wants to merge 23 commits into
Mod to dedicated ScoreMultiplierCalculator classes#650Rian8337 wants to merge 23 commits into
Conversation
…eMultiplierCalculator`
…n multiplier calculation
Rian8337
added
the
release-stream:main
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
Mod.scoreMultiplierandMod.migrationScoreMultiplierinModclasses to dedicatedScoreMultiplierCalculatorclasses. This makes it easier to perform mod score multiplier changes as the "legacy" score multipliers as per database version 5 are kept inLegacyScoreMultiplierCalculator. This means we do not need to overridemigrationScoreMultiplierwith old values if we want to changescoreMultiplier, which is easy to miss.ScoreMultiplierCalculatorincludes multipliers that have not been finalized yet. See TODO.