Conversation
Add go.mod / go.sum with pinned dependencies.
The test relied on os.Args being empty, but go test injects its own flags (e.g. -test.testlogfile).
Fixes: Insecure Temp File Reuse in its extract_zipped_paths()
Note that the golang folks did not stop and appreciate the Wisdom of
Years of Python for the indentation and came up with this mess:
if strings.ContainsRune(key, '.') ||
- strings.ContainsRune(key, 0) ||
- strings.HasPrefix(key, "$") {
+ strings.ContainsRune(key, 0) ||
+ strings.HasPrefix(key, "$") {
log.Log.Printf("possibly problematic key: %s", key)
This is stupid. But we're not going to fight gofmt this time.
Life is too short.
See the recommended Python practice:
# Add some extra indentation on the conditional continuation line.
if (this_is_one_thing
and that_is_another_thing):
do_something()
Upstream-Bug: golang/go#48064
app.* collectors are sampled every ~24 min (4h / sample_n, default 10) and snapshots saved to /var/spool/gocollect/<key>/<timestamp>.json. At push time the most frequently occurring value (mode) across the last N snapshots is pushed instead of a fresh run, filtering out transient changes like short-lived processes. New spool package: Save() writes a snapshot and trims old files; LoadMode() returns the mode across the last N snapshots. Runner gains SpoolPath, SampledN, SampledPrefixes fields. The main loop is restructured: Sample() runs every sampleInterval, Run() is called every N samples. SIGHUP/SIGUSR1 forces an immediate push. --one-shot bypasses sampling and goes straight to Run(). Falls back to a live run when the spool is empty (first startup). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This will be one of the sampled collectors. Change: osso-org/changes#2389
Urth
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.