Skip to content

Updated protobuf to 4.24.4#27

Open
biodranik wants to merge 1 commit into
masterfrom
ab-protobuf
Open

Updated protobuf to 4.24.4#27
biodranik wants to merge 1 commit into
masterfrom
ab-protobuf

Conversation

@biodranik

Copy link
Copy Markdown
Member

Comment thread README.md Outdated
pip3 install -r requirements.txt
```

Updating protobuf in the repo should be synced with Kothik.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Updating protobuf in the repo should be synced with Kothik.
Updating protobuf in the repo should be synced with Kothic.

Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik

biodranik commented Oct 15, 2023

Copy link
Copy Markdown
Member Author

@pastk regenerating drules with newer protobuf from this branch doesn't show any local changes. Is it expected?

@pastk

pastk commented Oct 15, 2023

Copy link
Copy Markdown

Looks like the binary format didn't change (at least in the part used by us).

@pastk

pastk commented May 9, 2024

Copy link
Copy Markdown

@AndrewShkrob There is a tools/python/stylesheet/drules_struct_pb2.py file in the main repo which hasn't been updated accordingly, this versions discrepancy is likely causing organicmaps/organicmaps#8113 (comment)

Probably all scripts should be changed to use the drules_struct_pb2.py file from the kothic repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants