[GR-62166] Add an option to turn off implicit interop in Espresso#13709
Open
graalvmbot wants to merge 2 commits into
Open
[GR-62166] Add an option to turn off implicit interop in Espresso#13709graalvmbot wants to merge 2 commits into
graalvmbot wants to merge 2 commits into
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option (java.EnableImplicitInterop) for Espresso.
With implicit interop, a group of bytecodes (like array operations, field accesses) delegates to interop messages when they see foreign objects. The
noForeignObjectsassumption inBytecodeNodeis maintained so that we can avoid checking foreign markers when foreign objects are never seen. When implicit interop is turned off, those bytecodes no longer take foreign objects into account and only work for Espresso objects. As a result, we don't need to maintain this assumption in this mode and therefore reduce the runtime overhead ofcheckNoForeignObjectAssumption.We can safely do this, because in this mode a foreign object (any static object with the foreign marker) is never typed as an array or a class instance that has fields. Therefore, at the boundary of languages, only a selected subset of foreign object conversions is allowed in this mode.