Skip to content

Migrate Node.js from 20 to 24 LTS#896

Merged
bilalabbad merged 2 commits intostablefrom
bab-update-node
Mar 26, 2026
Merged

Migrate Node.js from 20 to 24 LTS#896
bilalabbad merged 2 commits intostablefrom
bab-update-node

Conversation

@bilalabbad
Copy link
Copy Markdown
Contributor

@bilalabbad bilalabbad commented Mar 26, 2026

Summary by CodeRabbit

  • Chores
    • Updated Node.js version in documentation build workflows.

@bilalabbad bilalabbad self-assigned this Mar 26, 2026
@bilalabbad bilalabbad changed the title Migrate Node.js from 20 to 24 LT Migrate Node.js from 20 to 24 LTS Mar 26, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

Warning

Rate limit exceeded

@bilalabbad has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9f44ad10-4afb-4e07-9390-6fa18a8b9f65

📥 Commits

Reviewing files that changed from the base of the PR and between efa1ac5 and 443db8b.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Walkthrough

The GitHub Actions workflow configuration is updated to use Node.js version 24 instead of version 20. The change applies to two jobs: "documentation" and "validate-generated-documentation", where the node-version parameter passed to the actions/setup-node@v5 action is modified. This affects how the Node.js environment is initialized during the execution of these workflow jobs.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, leaving required context sections (Why, What changed, How to review, How to test, Impact & rollout) completely empty. Add a pull request description following the template with sections explaining the rationale for the Node.js upgrade, behavioral impact, testing approach, and any rollout considerations.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating Node.js version from 20 to 24 LTS in the CI workflow configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the group/ci Issue related to the CI pipeline label Mar 26, 2026
@bilalabbad bilalabbad requested review from a team and fatih-acar March 26, 2026 17:11
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 26, 2026

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 443db8b
Status: ✅  Deploy successful!
Preview URL: https://96952786.infrahub-sdk-python.pages.dev
Branch Preview URL: https://bab-update-node.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##           stable     #896   +/-   ##
=======================================
  Coverage   80.68%   80.68%           
=======================================
  Files         119      119           
  Lines       10335    10335           
  Branches     1550     1550           
=======================================
  Hits         8339     8339           
  Misses       1473     1473           
  Partials      523      523           
Flag Coverage Δ
integration-tests 41.59% <ø> (ø)
python-3.10 51.82% <ø> (-0.02%) ⬇️
python-3.11 51.84% <ø> (+0.01%) ⬆️
python-3.12 51.82% <ø> (-0.02%) ⬇️
python-3.13 51.84% <ø> (ø)
python-3.14 53.54% <ø> (+0.01%) ⬆️
python-filler-3.12 24.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bilalabbad bilalabbad changed the base branch from develop to stable March 26, 2026 17:32
@bilalabbad bilalabbad changed the base branch from stable to develop March 26, 2026 17:32
@bilalabbad bilalabbad changed the base branch from develop to stable March 26, 2026 17:34
@bilalabbad bilalabbad merged commit d8c5f68 into stable Mar 26, 2026
21 checks passed
@bilalabbad bilalabbad deleted the bab-update-node branch March 26, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/ci Issue related to the CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants