Fix nil pointer dereference in sortUnpackJobs when sorting non-failed jobs#3793
Open
jianzhangbjz wants to merge 1 commit intooperator-framework:masterfrom
Open
Fix nil pointer dereference in sortUnpackJobs when sorting non-failed jobs#3793jianzhangbjz wants to merge 1 commit intooperator-framework:masterfrom
jianzhangbjz wants to merge 1 commit intooperator-framework:masterfrom
Conversation
… jobs Signed-off-by: Jian Zhang <[email protected]>
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Added a nil check before accessing
LastTransitionTime. When both conditions are nil (i.e., both jobs have not failed), fall back to sorting byCreationTimestampinstead.condIandcondJin the sort comparison functionMotivation for the change:
The catalog-operator crashes with a nil pointer dereference panic when sorting unpack jobs:
In
sortUnpackJobs(), when comparing two jobs that both have not failed (failedI == false && failedJ == false), thegetCondition()function returnsnilfor bothcondIandcondJ. The code then attempts to accesscondI.LastTransitionTimewithout a nil check, causing the panic.More details: https://issues.redhat.com/browse/OCPBUGS-77179
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issueAssisted-By: Claude-Code