Skip to content

delete obsolete files and shift webhook testing to use a kube-native approach#3792

Merged
openshift-merge-bot[bot] merged 2 commits intooperator-framework:masterfrom
grokspawn:ci-investigation
Mar 12, 2026
Merged

delete obsolete files and shift webhook testing to use a kube-native approach#3792
openshift-merge-bot[bot] merged 2 commits intooperator-framework:masterfrom
grokspawn:ci-investigation

Conversation

@grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Mar 10, 2026

Description of the change:

  1. identify obsolete artifacts in the repo that we can remove, thus reducing the problem domain some
  2. shift e2e webhook testing to use the webhook-operator version which replaces the kube-rbac-proxy with kube api approaches
  3. profit!

Motivation for the change:
gcr.io/kubebuilder/kube-rbac-proxy is gone, and there are still test bundles/images in OLM-land that rely on it.

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@grokspawn grokspawn changed the title diving CI problems by debriding investigating CI problems Mar 11, 2026
@grokspawn grokspawn marked this pull request as ready for review March 12, 2026 14:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2026
@openshift-ci openshift-ci bot requested review from dtfranz and pedjak March 12, 2026 14:23
@grokspawn grokspawn changed the title investigating CI problems delete obsolete files and shift webhook testing to use a kube-native approach Mar 12, 2026
@grokspawn grokspawn requested review from perdasilva and tmshort March 12, 2026 14:30
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
The removed files are all in deploy/upstream/manifests

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2026
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 50e42fb into operator-framework:master Mar 12, 2026
14 checks passed
@grokspawn grokspawn deleted the ci-investigation branch March 12, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants