Skip to content

[backport] #716: [fix] Stopped trusting X-Forwarded-For for the client IP address (to 26.09) - #723

Merged
nemesifier merged 1 commit into
26.09from
backport/716-to-26.09-1792454318
Oct 20, 2026
Merged

nemesifier merged 1 commit into
26.09from
backport/716-to-26.09-1792454318

Conversation

@openwisp-companion

Copy link
Copy Markdown

Backport of #716 to 26.09.

Removed the vulnerable ``NINGX_REAL_REMOTE_ADDR`` configuration
and added ``NGINX_TRUSTED_PROXIES`` to safely validate proxy IP
addresses before trusting the ``X-Forwarded-For`` header.

Advisory: **GHSA-hvmx-g7m2-vqx8**.

[backport 26.09]

(cherry picked from commit 975d2f3)
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1
  • ai-review
🚫 Excluded labels (none allowed): 1
  • invalid

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 23866c82-3549-4b0a-a4af-4d8d36517aab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@nemesifier
nemesifier merged commit c90f99f into 26.09 Oct 20, 2026
3 of 4 checks passed
@nemesifier
nemesifier deleted the backport/716-to-26.09-1792454318 branch October 20, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants