fix: Remove aggressive precision check in share pool to fix alpha tx fees #2363
+46
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the overly aggressive precision check in the share pool that forced full unstake when partial unstake was requested. The previous implementation would force-remove all stake when the remaining share fraction dropped below 0.00001 or when the denominator appeared "too low" after emissions. This caused problems when paying transaction fees in alpha because there was no way to return unused portions of unstaked TAO.
The fix simplifies the precision handling to only clean up shares when the remaining value is truly negligible (less than 1 unit), allowing partial unstakes to succeed as expected.
Related Issue(s)
Type of Change
Breaking Change
N/A - This is a bug fix that removes an error condition. Existing code that handled
PrecisionLosserrors will no longer receive them, but operations will succeed instead of failing.Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
N/A
Additional Notes
Files changed:
primitives/share-pool/src/lib.rs- Simplified precision handling inupdate_value_for_one()pallets/subtensor/src/macros/errors.rs- RemovedPrecisionLosserror variantpallets/subtensor/src/staking/recycle_alpha.rs- RemovedPrecisionLosscheckspallets/subtensor/src/tests/recycle_alpha.rs- Updated tests to verify operations succeedPotential Reviewers: @const-t @opentensor/core-devs