Filter incorrect subnet owner calls in TransactionExtension (#2338) #2362
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements filtering of incorrect subnet owner transactions in
TransactionExtensionto prevent them from entering the transaction pool. The validation happens early in the transaction lifecycle, rejecting signed transactions from non-owners before they are added to the pool. Root origin transactions are allowed to pass through (since they cannot be detected in TransactionExtension) and are properly validated in the dispatch functions.Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
N/A - This is a bug fix that adds validation to prevent invalid transactions from entering the pool. Existing valid transactions continue to work as before.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
N/A
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.
Implementation Details:
InvalidSubnetOwnervariant toCustomTransactionErrorenum with error code 21is_subnet_owner()helper function inSubtensorTransactionExtensionto check ownershipTransactionExtension::validate()for:start_call- requires subnet owner (usesensure_subnet_owner)update_symbol- requires subnet owner or root (usesensure_subnet_owner_or_root)sudo_set_root_claim_threshold- requires subnet owner or root (usesensure_subnet_owner_or_root)Behavior:
InvalidSubnetOwnererror at transaction pool level ✓Potential Reviewers:
@l0r1s