Add exec probe handler support to probes API#696
Open
zzzeek wants to merge 1 commit into
Open
Conversation
fmount
reviewed
May 19, 2026
zzzeek
force-pushed
the
OSPRH-30190
branch
2 times, most recently
from
35f2321 to
f7a36c5
Compare
fmount
reviewed
May 20, 2026
Contributor
fmount
left a comment
fmount
left a comment
There was a problem hiding this comment.
Looks like we're going to the right direction here. I think we're almost good but I have an additional question on code cleanup after I checked the existing operators using this feature. It can go on a follow up though, but would be good to address while we're designing the V2 here.
Add ProbeHandlerType (HTTP/Exec) and Command/Port/Scheme fields to ProbeConf. Introduce SetProbeConfV2 and CreateProbeSetV2 with a self-contained ProbeConf signature that switches on handler type. Export Merge for downstream use. Existing SetProbeConf/CreateProbeSet delegate to V2 for full backward compatibility. References: OSPRH-30190 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
|
/lgtm |
fmount
approved these changes
May 25, 2026
Contributor
|
@zzzeek I would have renamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ProbeHandlerType (HTTP/Exec) and Command/Port/Scheme fields to ProbeConf. Introduce SetProbeConfV2 and CreateProbeSetV2 with a self-contained ProbeConf signature that switches on handler type. Export Merge for downstream use. Existing SetProbeConf/CreateProbeSet delegate to V2 for full backward compatibility.
References: OSPRH-30190