Update prowgen when CSI is enabled

[psalajova]

Updates prowgen with gsm-project-config arg (which ci-operator needs to successfully create GSM clients) and fixes missing enable-secrets-store-csi-driver=true flag in test.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 531f6280-9570-4eec-a593-18917a70456a

📥 Commits

Reviewing files that changed from the base of the PR and between 2c99cd8 and bd4bbeb.

📒 Files selected for processing (1)

• pkg/steps/multi_stage/csi_utils_test.go

---

Walkthrough

Adds new GSM/CSI-related exported constants, wires a CSI credentials volume/mount into pod specs via a new BuildCSIVolume helper, removes duplicate explicit CSI arg additions in prow job builder, updates fixtures and CLI comment, and adds tests — no business logic changes beyond wiring and constants.

Changes

Cohort / File(s)	Summary
Constants pkg/api/constant.go	Adds GSM/CSI CLI and mount constants (GSMProjectConfigParameter, EnableCSIFlag, GSMCredentialsVolumeMount, GSMCredentialsMountPath, GSMCredentialsParameter, GSMCiOperatorSPCName) and re-formats existing GSM constants.
Podspec & Jobbase pkg/prowgen/podspec.go, pkg/prowgen/jobbase.go	GSMConfig() now wires CSI credentials volume/mount and appends GSM CSI-related parameters; NewProwJobBaseBuilderForTest no longer redundantly adds an explicit enable-secrets-store-csi-driver arg in certain branches. Volume/mount ops now surface errors.
Test fixtures pkg/prowgen/testdata/zz_fixture_TestGSMConfig_add_gsm_config_volume_and_mount.yaml, pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_CSI_enabled.yaml	Updated expected container args to include GSM project/credentials flags and added a read-only CSI volume gsm-sa-key plus /etc/gsm-credentials mount.
CSI helper & multi-stage usage pkg/steps/multi_stage/csi_utils.go, pkg/steps/multi_stage/gen.go, pkg/steps/multi_stage/multi_stage.go	Adds exported BuildCSIVolume(name, spcName) coreapi.Volume which centralizes CSI Volume construction; replaces inline CSI volume creations with calls to this helper.
CSI helper tests pkg/steps/multi_stage/csi_utils_test.go	Adds unit test TestBuildCSIVolume validating the constructed CSI volume has driver secrets-store.csi.k8s.io, ReadOnly: true, and secretProviderClass attribute.
CLI comment cmd/ci-operator/main.go	Inserted a // Google Secret Manager flags comment above existing GSM-related flag registrations; no flag semantics changed.
Minor cleanup pkg/gsm-validation/gsm.go	Removed an example comment from NormalizeName; no behavioral change.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

[psalajova]

/hold

[Prucek]

this will be used by every ci-operator prowjob? We should think about using presets: #4994

[psalajova]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[psalajova]

@Prucek re #5018 (comment) , Presets would be amazing here, but it looks like they won't be available for now, so until they are I added the volumes and other stuff as normal

[psalajova]

/unhold

[danilo-gemoli]

Do we have unit tests that cover the changes in these files?

pkg/steps/multi_stage/gen.go
pkg/steps/multi_stage/multi_stage.go

[psalajova]

Do we have unit tests that cover the changes in these files?

pkg/steps/multi_stage/gen.go
pkg/steps/multi_stage/multi_stage.go

You are right, the prowgen fixtures test the end-to-end behavior but don't specifically test BuildCSIVolume() func... I'll add some unit test for that 👍

[psalajova]

@danilo-gemoli Added the unit test (for TestBuildCSIVolume() func) in the latest commit. The changes are mainly just replacing the extra code with the BuildCSIVolume() func, and the correctness is also tested in pkg/steps/multi_stage/gen_test.go in TestAddCSICredentials test.

[danilo-gemoli]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, psalajova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [danilo-gemoli,psalajova]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[psalajova]

/test e2e

[psalajova]

/override ci/prow/images

[openshift-ci-robot]

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

[openshift-ci]

@psalajova: Overrode contexts on behalf of psalajova: ci/prow/images

Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@psalajova: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/breaking-changes	bd4bbeb	link	false	/test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.