Skip to content

(WIP) MCO-1480 #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
isabella-janssen wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

(WIP) MCO-1480 #2647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions machineconfiguration/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,11 @@ type MachineConfigPoolSpec struct {
// to stop updates, use the 'paused' property instead. Drain will respect
// Pod Disruption Budgets (PDBs) such as etcd quorum guards, even if
// maxUnavailable is greater than one.
// When specified as an integer, the value must be greater than 0.
// When specified as a string, it must be a percentage (e.g., "50%").
// +optional
// +kubebuilder:validation:XIntOrString
// +kubebuilder:validation:XValidation:rule="type(self) == int ? self > 0 : type(self) == string && self.matches('^[0-9]+%$')",message="must be a positive integer greater than 0, or a percentage string (e.g., '50%')"
MaxUnavailable *intstr.IntOrString `json:"maxUnavailable,omitempty"`

// The targeted MachineConfig object for the machine config pool.
Expand Down
6 changes: 6 additions & 0 deletions ...rated.crd-manifests/0000_80_machine-config_01_machineconfigpools-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ spec:
to stop updates, use the 'paused' property instead. Drain will respect
Pod Disruption Budgets (PDBs) such as etcd quorum guards, even if
maxUnavailable is greater than one.
When specified as an integer, the value must be greater than 0.
When specified as a string, it must be a percentage (e.g., "50%").
x-kubernetes-int-or-string: true
x-kubernetes-validations:
- message: must be a positive integer greater than 0, or a percentage
string (e.g., '50%')
rule: 'type(self) == int ? self > 0 : type(self) == string && self.matches(''^[0-9]+%$'')'
nodeSelector:
description: nodeSelector specifies a label selector for Machines
properties:
Expand Down
6 changes: 6 additions & 0 deletions .../zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ spec:
to stop updates, use the 'paused' property instead. Drain will respect
Pod Disruption Budgets (PDBs) such as etcd quorum guards, even if
maxUnavailable is greater than one.
When specified as an integer, the value must be greater than 0.
When specified as a string, it must be a percentage (e.g., "50%").
x-kubernetes-int-or-string: true
x-kubernetes-validations:
- message: must be a positive integer greater than 0, or a percentage
string (e.g., '50%')
rule: 'type(self) == int ? self > 0 : type(self) == string && self.matches(''^[0-9]+%$'')'
nodeSelector:
description: nodeSelector specifies a label selector for Machines
properties:
Expand Down
6 changes: 6 additions & 0 deletions ...d.crd-manifests/0000_80_machine-config_01_machineconfigpools-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ spec:
to stop updates, use the 'paused' property instead. Drain will respect
Pod Disruption Budgets (PDBs) such as etcd quorum guards, even if
maxUnavailable is greater than one.
When specified as an integer, the value must be greater than 0.
When specified as a string, it must be a percentage (e.g., "50%").
x-kubernetes-int-or-string: true
x-kubernetes-validations:
- message: must be a positive integer greater than 0, or a percentage
string (e.g., '50%')
rule: 'type(self) == int ? self > 0 : type(self) == string && self.matches(''^[0-9]+%$'')'
nodeSelector:
description: nodeSelector specifies a label selector for Machines
properties:
Expand Down
6 changes: 6 additions & 0 deletions ...n/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ spec:
to stop updates, use the 'paused' property instead. Drain will respect
Pod Disruption Budgets (PDBs) such as etcd quorum guards, even if
maxUnavailable is greater than one.
When specified as an integer, the value must be greater than 0.
When specified as a string, it must be a percentage (e.g., "50%").
x-kubernetes-int-or-string: true
x-kubernetes-validations:
- message: must be a positive integer greater than 0, or a percentage
string (e.g., '50%')
rule: 'type(self) == int ? self > 0 : type(self) == string && self.matches(''^[0-9]+%$'')'
nodeSelector:
description: nodeSelector specifies a label selector for Machines
properties:
Expand Down
6 changes: 6 additions & 0 deletions ....crd-manifests/0000_80_machine-config_01_machineconfigpools-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ spec:
to stop updates, use the 'paused' property instead. Drain will respect
Pod Disruption Budgets (PDBs) such as etcd quorum guards, even if
maxUnavailable is greater than one.
When specified as an integer, the value must be greater than 0.
When specified as a string, it must be a percentage (e.g., "50%").
x-kubernetes-int-or-string: true
x-kubernetes-validations:
- message: must be a positive integer greater than 0, or a percentage
string (e.g., '50%')
rule: 'type(self) == int ? self > 0 : type(self) == string && self.matches(''^[0-9]+%$'')'
nodeSelector:
description: nodeSelector specifies a label selector for Machines
properties:
Expand Down
6 changes: 6 additions & 0 deletions ...gated-crd-manifests/machineconfigpools.machineconfiguration.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ spec:
to stop updates, use the 'paused' property instead. Drain will respect
Pod Disruption Budgets (PDBs) such as etcd quorum guards, even if
maxUnavailable is greater than one.
When specified as an integer, the value must be greater than 0.
When specified as a string, it must be a percentage (e.g., "50%").
x-kubernetes-int-or-string: true
x-kubernetes-validations:
- message: must be a positive integer greater than 0, or a percentage
string (e.g., '50%')
rule: 'type(self) == int ? self > 0 : type(self) == string && self.matches(''^[0-9]+%$'')'
nodeSelector:
description: nodeSelector specifies a label selector for Machines
properties:
Expand Down
6 changes: 6 additions & 0 deletions ...regated-crd-manifests/machineconfigpools.machineconfiguration.openshift.io/OSStreams.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ spec:
to stop updates, use the 'paused' property instead. Drain will respect
Pod Disruption Budgets (PDBs) such as etcd quorum guards, even if
maxUnavailable is greater than one.
When specified as an integer, the value must be greater than 0.
When specified as a string, it must be a percentage (e.g., "50%").
x-kubernetes-int-or-string: true
x-kubernetes-validations:
- message: must be a positive integer greater than 0, or a percentage
string (e.g., '50%')
rule: 'type(self) == int ? self > 0 : type(self) == string && self.matches(''^[0-9]+%$'')'
nodeSelector:
description: nodeSelector specifies a label selector for Machines
properties:
Expand Down
6 changes: 6 additions & 0 deletions ...ated-crd-manifests/machineconfigpools.machineconfiguration.openshift.io/PinnedImages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ spec:
to stop updates, use the 'paused' property instead. Drain will respect
Pod Disruption Budgets (PDBs) such as etcd quorum guards, even if
maxUnavailable is greater than one.
When specified as an integer, the value must be greater than 0.
When specified as a string, it must be a percentage (e.g., "50%").
x-kubernetes-int-or-string: true
x-kubernetes-validations:
- message: must be a positive integer greater than 0, or a percentage
string (e.g., '50%')
rule: 'type(self) == int ? self > 0 : type(self) == string && self.matches(''^[0-9]+%$'')'
nodeSelector:
description: nodeSelector specifies a label selector for Machines
properties:
Expand Down
2 changes: 1 addition & 1 deletion machineconfiguration/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.