Normalize version numbers in FindJavaVersion
#969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace raw version strings with normalized major versions in the `JavaVersionTable` data table. This addresses issue #968 where users expect normalized values like "8" instead of "1.8". - Use `getMajorVersion()` and `getMajorReleaseVersion()` instead of raw `getSourceCompatibility()` and `getTargetCompatibility()` fields - Update column descriptions to clarify they contain major versions Closes #968 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
Author
|
We already have two recipes that report in more detail
Figured good enough then to have this singular recipe only use major versions;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace raw version strings (e.g., "1.8", "11.0.15+10") with normalized major versions ("8", "11") in
FindJavaVersion's data tableUse
getMajorVersion()andgetMajorReleaseVersion()from theJavaVersionmarker instead of raw fieldsUpdate column descriptions in
JavaVersionTableto clarify they contain major versionsCloses FindJavaVersion (et al) -- normalize version numbers #968
Test plan
FindJavaVersionTestpasses🤖 Generated with Claude Code