Skip to content

Fix IExtensible::getExtension to find dynamically-added extensions #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bssth wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix IExtensible::getExtension to find dynamically-added extensions #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion include/component.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,15 @@ struct IExtensible
{
/// Try to get an extension by its UID
/// @return A pointer to the extension or nullptr if it's not supported
virtual IExtension* getExtension(UID id) { return nullptr; }
virtual IExtension* getExtension(UID id)
{
auto it = miscExtensions.find(id);
if (it != miscExtensions.end())
{
return it->second.first;
}
return nullptr;
}

/// Query an extension by its type
/// Don't call directly, use global queryExtension() instead
Expand Down