Skip to content

Add linux/arm64 support to build tooling#598

Closed
ryan-lane wants to merge 2 commits into
openkruise:masterfrom
mappedsky:master
Closed

Add linux/arm64 support to build tooling#598
ryan-lane wants to merge 2 commits into
openkruise:masterfrom
mappedsky:master

Conversation

@ryan-lane

Copy link
Copy Markdown

Ⅰ. Describe what this PR does

This change adds arm64 support to relevant docker images, which was missing for a number of images, making them impossible to install on arm servers.

Ⅱ. Does this pull request fix one issue?

I didn't open a specific issue, but there is a related open issue.

Fixes #269

Ⅲ. Describe how to verify it

Use the builder, changed in this PR, to make the various image builds.

Ⅳ. Special notes for reviews

Note that this change also changes some copy paths in the docker images, as they were failing BuildKit’s static checker, as they were out-of-context copies.

ryan-lane added 2 commits July 1, 2026 20:20
Signed-off-by: Ryan Lane <rlane32@gmail.com>
Signed-off-by: Ryan Lane <rlane32@gmail.com>
@kruise-bot kruise-bot requested review from AiRanthem and zmberg July 1, 2026 11:35
@kruise-bot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot

Copy link
Copy Markdown

Welcome @ryan-lane! It looks like this is your first PR to openkruise/agents 🎉

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.71%. Comparing base (e2ffc5a) to head (3fa6046).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #598   +/-   ##
=======================================
  Coverage   79.71%   79.71%           
=======================================
  Files         205      205           
  Lines       15287    15287           
=======================================
  Hits        12186    12186           
  Misses       2658     2658           
  Partials      443      443           
Flag Coverage Δ
unittests 79.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@googs1025

Copy link
Copy Markdown
Contributor

already in #545

@kruise-bot

Copy link
Copy Markdown

@ryan-lane: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ryan-lane

Copy link
Copy Markdown
Author

@googs1025 ah, I'll close in favor of that. Is there any progress there? I need arm64 images

@ryan-lane ryan-lane closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Deploying and building images on the ARM environment failed.

3 participants