Add linux/arm64 support to build tooling#598
Conversation
Signed-off-by: Ryan Lane <rlane32@gmail.com>
Signed-off-by: Ryan Lane <rlane32@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @ryan-lane! It looks like this is your first PR to openkruise/agents 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
=======================================
Coverage 79.71% 79.71%
=======================================
Files 205 205
Lines 15287 15287
=======================================
Hits 12186 12186
Misses 2658 2658
Partials 443 443
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
already in #545 |
|
@ryan-lane: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@googs1025 ah, I'll close in favor of that. Is there any progress there? I need arm64 images |
Ⅰ. Describe what this PR does
This change adds arm64 support to relevant docker images, which was missing for a number of images, making them impossible to install on arm servers.
Ⅱ. Does this pull request fix one issue?
I didn't open a specific issue, but there is a related open issue.
Fixes #269
Ⅲ. Describe how to verify it
Use the builder, changed in this PR, to make the various image builds.
Ⅳ. Special notes for reviews
Note that this change also changes some copy paths in the docker images, as they were failing BuildKit’s static checker, as they were out-of-context copies.