Skip to content

7904175: Empty option value can crash jextract#303

Open
nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
nizarbenalla:7904175
Open

7904175: Empty option value can crash jextract#303
nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
nizarbenalla:7904175

Conversation

@nizarbenalla
Copy link
Copy Markdown
Member

@nizarbenalla nizarbenalla commented Mar 31, 2026

Passing empty option values to jextract causes it to crash, this patch prevent that to happen.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (no review required)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/303/head:pull/303
$ git checkout pull/303

Update a local copy of the PR:
$ git checkout pull/303
$ git pull https://git.openjdk.org/jextract.git pull/303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 303

View PR using the GUI difftool:
$ git pr show -t 303

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/303.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 31, 2026

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

@nizarbenalla This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7904175: Empty option value can crash jextract

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ad6430f: Print IncludeKinds in consistent order
  • aedcb82: 7904115: Fix for AIX test case failures due to incorrect alignment for double and pointer

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@nizarbenalla nizarbenalla marked this pull request as ready for review March 31, 2026 12:28
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 31, 2026

Webrevs

Copy link
Copy Markdown
Member

@JornVernee JornVernee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the option parser code, but your changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants