7904175: Empty option value can crash jextract#303
7904175: Empty option value can crash jextract#303nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
Conversation
-issue an error
|
👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into |
|
@nizarbenalla This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
JornVernee
left a comment
There was a problem hiding this comment.
I'm not super familiar with the option parser code, but your changes look good to me.
Passing empty option values to jextract causes it to crash, this patch prevent that to happen.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/303/head:pull/303$ git checkout pull/303Update a local copy of the PR:
$ git checkout pull/303$ git pull https://git.openjdk.org/jextract.git pull/303/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 303View PR using the GUI difftool:
$ git pr show -t 303Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/303.diff
Using Webrev
Link to Webrev Comment