-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8373808: Refactor java/net/httpclient qpack and hpack tests to use JUnit #28900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8373808: Refactor java/net/httpclient qpack and hpack tests to use JUnit #28900
Conversation
|
👋 Welcome back aefimov! A progress list of the required criteria for merging this PR into |
|
@AlekseiEfimov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 40 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@AlekseiEfimov The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/integrate |
|
Going to push as commit 40755af.
Your commit was automatically rebased without conflicts. |
|
@AlekseiEfimov Pushed as commit 40755af. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The change below refactors QPack and HPack HttpClient tests to use the JUnit test framework instead of the TestNG one.
No failures of the modified tests seen with:
make test TEST=open/test/jdk/java/net/httpclient/http2/Hpack*\ open/test/jdk/java/net/httpclient/qpackTest-framework stats after the modification:
QPack tests:
Framework-based tests: 2,385 = 0 TestNG + 2,385 JUnitHPack tests:
Framework-based tests: 108 = 0 TestNG + 108 JUnitProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28900/head:pull/28900$ git checkout pull/28900Update a local copy of the PR:
$ git checkout pull/28900$ git pull https://git.openjdk.org/jdk.git pull/28900/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28900View PR using the GUI difftool:
$ git pr show -t 28900Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28900.diff
Using Webrev
Link to Webrev Comment