Skip to content

Conversation

@AlekseiEfimov
Copy link
Member

@AlekseiEfimov AlekseiEfimov commented Dec 18, 2025

The change below refactors QPack and HPack HttpClient tests to use the JUnit test framework instead of the TestNG one.
No failures of the modified tests seen with:
make test TEST=open/test/jdk/java/net/httpclient/http2/Hpack*\ open/test/jdk/java/net/httpclient/qpack

Test-framework stats after the modification:
QPack tests:
Framework-based tests: 2,385 = 0 TestNG + 2,385 JUnit
HPack tests:
Framework-based tests: 108 = 0 TestNG + 108 JUnit


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373808: Refactor java/net/httpclient qpack and hpack tests to use JUnit (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28900/head:pull/28900
$ git checkout pull/28900

Update a local copy of the PR:
$ git checkout pull/28900
$ git pull https://git.openjdk.org/jdk.git pull/28900/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28900

View PR using the GUI difftool:
$ git pr show -t 28900

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28900.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2025

👋 Welcome back aefimov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@AlekseiEfimov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373808: Refactor java/net/httpclient qpack and hpack tests to use JUnit

Reviewed-by: djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@AlekseiEfimov The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 18, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2025
@AlekseiEfimov
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

Going to push as commit 40755af.
Since your change was applied there have been 40 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 23, 2025
@openjdk openjdk bot closed this Dec 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2025
@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@AlekseiEfimov Pushed as commit 40755af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated net [email protected]

Development

Successfully merging this pull request may close these issues.

2 participants