8373650: Test javax/swing/JMenuItem/6458123/ManualBug6458123.java fails because the check icons are not aligned properly as expected

[prsadhuk]

Check/radiobutton icon are not aligned properly in RTL. WindowsMenuItemUI uses MenuItemLayoutHelper.layoutMenuItem to do the layout which calls doRTLColumnLayout which calculates x positions in calcXPositionsRTL and then again aligns in alignRects. However, since in Windows historically radiobutton/check icon was not drawn or drawn below the menuitem image icon (since image icon and check icon was drawn in the same layout space and not separately) the aligned x position of check icons returned from MenuItemLayoutHelper was not correct but since MenuItemLayoutHelper alignment is used in other L&Fs also so we need to realign it in windows specific class i.e in WindowsIconFactory in paintIcon

Before fix

After fix

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8373650

Issue

• JDK-8373650: Test "javax/swing/JMenuItem/6458123/ManualBug6458123.java" fails because the check icons are not aligned properly as expected (Bug - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28889/head:pull/28889
$ git checkout pull/28889

Update a local copy of the PR:
$ git checkout pull/28889
$ git pull https://git.openjdk.org/jdk.git pull/28889/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28889

View PR using the GUI difftool:
$ git pr show -t 28889

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28889.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[prsadhuk]

/touch

[openjdk]

@prsadhuk The pull request is being re-evaluated and the inactivity timeout has been reset.

[mlbridge]

Webrevs

• 00: Full (f0b99274)

[mrserb]

Check/radiobutton icon are not aligned properly in RTL.

What is the proper alignment in this context? The “After fix” image shows that the icons still jump left and right.

[DamonGuy]

Any reason why the "After fix" image also has the "Radio button" dot misaligned still?