Conversation
WalkthroughAdds Hawaii as a new map: data and manifest files, registers it in the map generator and playlist, exposes it in game map types, updates English localization, and adds credits entries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I'm not sure at all but this map might be too big? |
Duwibi
left a comment
There was a problem hiding this comment.
Simular to Flo, I also think the map would be too big to be able to be queued for public lobbies. With that size, it would probably lag on PC, let alone on lower-end phones and tablets. How did your own testing go?
The other thing I wanna ask is what base map did you use? (It needs to have copyright rules which allow for commercial use).
Overall, if the base map isn't under strict copyright and it runns somewhat smoothly, we could add it to the game to be played in singleplayer and private lobbies. But it's definitely too big for public lobbies imo 🤔
|
I played a few solo matches on this map with no issues, though it was on a M4 MBA. I increased the size because it felt a bit cramped when it was Faroe-Island-map-sized-ish, but happy to scale it down. Source is this licensed under Creative Commons |
evanpelle
left a comment
There was a problem hiding this comment.
Since the map is license by-sa, please add attribution in the CREDITS.md
Done |
|
Scaled down the map from 3920x2544 (612K land tiles) to 3200x2076 (408K land tiles) |
Duwibi
left a comment
There was a problem hiding this comment.
I think it's ok for now. If it causes performence issues during the playtest, we can always remove it from public lobbies :)
|
Thanks guys! |
Description:
Add Hawaii as a new regional map. Features 9 nations across the Hawaiian island chain (Niihau, Kauai, Oahu, Molokai, Lanai, Kahoolawe, Maui, Kona, Hilo).
612K land tiles at 3920x2544408K land tiles at 3200x2076, terrain generated from real relief data with accurate volcanic peaks and coastal lowlands. Playlist frequency: 4.Checklist
Source: https://commons.wikimedia.org/wiki/File:USA_Hawaii_relief_location_map.svg
Discord: gabigabogabu