-
Notifications
You must be signed in to change notification settings - Fork 827
Add new map: Bosphorus Straits #2927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add new map: Bosphorus Straits #2927
Conversation
WalkthroughAdded a new "Bosphorus Straits" map: map assets and manifest, registration in map-generator, localization entry, Game enum inclusion, and playlist weight. Changes
Sequence Diagram(s)sequenceDiagram
participant Playlist as MapPlaylist (Server)
participant Game as GameMapType / MapCategories
participant Generator as MapGenerator
participant Resources as Map Assets / Manifest
Playlist->>Game: reference BosphorusStraits in frequency map
Game->>Generator: include GameMapType.BosphorusStraits in regional category
Generator->>Resources: load `resources/maps/bosphorusstraits/manifest.json` and `map-generator/assets/.../info.json`
Resources-->>Generator: return manifest and nations data
Generator-->>Playlist: make map available for selection
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description:
Adds a new Bosphorus Map (Turkey). One of the key strategic locations in the world and control access to the Black Sea. Smaller map that most to facilitate smaller FFA and Team games. Added are a selection of nations that correspond to the location.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
TSProphet