Skip to content

Conversation

@TsProphet94
Copy link
Contributor

Description:

Adds a new Bosphorus Map (Turkey). One of the key strategic locations in the world and control access to the Black Sea. Smaller map that most to facilitate smaller FFA and Team games. Added are a selection of nations that correspond to the location.

image

Image 16-01-2026 at 17 39
Image 16-01-2026 at 17 39 (1)

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

TSProphet

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Walkthrough

Added a new "Bosphorus Straits" map: map assets and manifest, registration in map-generator, localization entry, Game enum inclusion, and playlist weight.

Changes

Cohort / File(s) Summary
Map data & manifest
map-generator/assets/maps/bosphorusstraits/info.json, resources/maps/bosphorusstraits/manifest.json
New JSON files defining the Bosphorus Straits map: map metadata, nations with coordinates and flags, scaled variants, and land tile counts. Verify coordinates, names, and tile counts.
Map generator registry
map-generator/main.go
Added bosphorusstraits to the map registry. Check name consistency with resources and manifest.
Localization
resources/lang/en.json
Added "bosphorusstraits": "Bosphorus Straits" to English translations. Confirm key and punctuation.
Game types & classification
src/core/game/Game.ts
Added GameMapType.BosphorusStraits and included it in mapCategories.regional. Ensure enum string matches manifest/name.
Playlist weighting
src/server/MapPlaylist.ts
Added BosphorusStraits: 3 to the map frequency mapping. Confirm intended weight and no unintended removals.

Sequence Diagram(s)

sequenceDiagram
    participant Playlist as MapPlaylist (Server)
    participant Game as GameMapType / MapCategories
    participant Generator as MapGenerator
    participant Resources as Map Assets / Manifest

    Playlist->>Game: reference BosphorusStraits in frequency map
    Game->>Generator: include GameMapType.BosphorusStraits in regional category
    Generator->>Resources: load `resources/maps/bosphorusstraits/manifest.json` and `map-generator/assets/.../info.json`
    Resources-->>Generator: return manifest and nations data
    Generator-->>Playlist: make map available for selection
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

New shores appear on the game-board tide,
Pins and flags now stand side by side,
Small JSON whispers, maps align,
Bosphorus lights on the game-design,
Sail on, new map — the players ride. 🚢🗺️

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'Add new map: Bosphorus Straits' directly and clearly summarizes the main change—adding a new map to the system.
Description check ✅ Passed The pull request description is directly related to the changeset, providing context about the new Bosphorus Straits map, its strategic purpose, intended use case, and includes supporting screenshots.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 16, 2026
@ryanbarlow97 ryanbarlow97 added this to the v30 milestone Jan 20, 2026
@iiamlewis iiamlewis added the Maps A new map, or adjustments to an existing map itself, its json, etc, label Jan 22, 2026
coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maps A new map, or adjustments to an existing map itself, its json, etc,

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants