Repository navigation
ofAppEGLWindow: fix build on armv6l/armv7l - #8662
Merged
Merged
Conversation
Member
Author
|
Verified on a native armv7l build (Debian bookworm armhf userland, GCC 12) in https://github.com/danoli3/ofLinuxTestScripts, using this change on top of current master: Unrelated to this change: that run still ends with one unit test failure ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ofAppEGLWindow.cppno longer compiles, which breaks a native build on 32-bit ARM Linux (armv6l/armv7l), where the makefile builds the EGL/GLES window. On x86_64 and aarch64 the GLFW window is used and this file is skipped, so it went unnoticed.Errors from a native armv7l build (Debian bookworm armhf):
Changes:
CASE_STRnow doescase x: return yinstead of assigning to an undeclaredstr. This also fixes the missing return.settings.glesVersionMajor()/glesVersionMinor()becomegetGLESVersionMajor()/getGLESVersionMinor().ofGLESWindowSettingsexposes plain members plus those getters, not methods with the old names.Testing: not yet compiled on a Pi-class target locally. It is being checked by a native armv7l build in https://github.com/danoli3/ofLinuxTestScripts, and I'll update this PR with the result.