Skip to content

ofAppEGLWindow: fix build on armv6l/armv7l - #8662

Merged
danoli3 merged 1 commit into
openframeworks:masterfrom
danoli3:fix-egl-window-armv7
Nov 9, 2026
Merged

danoli3 merged 1 commit into
openframeworks:masterfrom
danoli3:fix-egl-window-armv7

Conversation

@danoli3

@danoli3 danoli3 commented Nov 9, 2026

Copy link
Copy Markdown
Member

ofAppEGLWindow.cpp no longer compiles, which breaks a native build on 32-bit ARM Linux (armv6l/armv7l), where the makefile builds the EGL/GLES window. On x86_64 and aarch64 the GLFW window is used and this file is skipped, so it went unnoticed.

Errors from a native armv7l build (Debian bookworm armhf):

ofAppEGLWindow.cpp:149:31: error: 'str' was not declared in this scope
ofAppEGLWindow.cpp:444:37: error: 'struct ofAppEGLWindowSettings' has no member named 'glesVersionMajor'
ofAppEGLWindow.cpp:445:53: error: expression cannot be used as a function
ofAppEGLWindow.cpp:170:1: error: control reaches end of non-void function [-Werror=return-type]

Changes:

  • CASE_STR now does case x: return y instead of assigning to an undeclared str. This also fixes the missing return.
  • settings.glesVersionMajor() / glesVersionMinor() become getGLESVersionMajor() / getGLESVersionMinor(). ofGLESWindowSettings exposes plain members plus those getters, not methods with the old names.

Testing: not yet compiled on a Pi-class target locally. It is being checked by a native armv7l build in https://github.com/danoli3/ofLinuxTestScripts, and I'll update this PR with the result.

@danoli3

danoli3 commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

Verified on a native armv7l build (Debian bookworm armhf userland, GCC 12) in https://github.com/danoli3/ofLinuxTestScripts, using this change on top of current master: ofAppEGLWindow.cpp now compiles and the core builds, and the unit tests run. The four errors in the description are gone.

Unrelated to this change: that run still ends with one unit test failure (ofRectangleTests crashes in ofBaseApp setup under QEMU), which I'm looking at separately.

@danoli3
danoli3 merged commit 39f0f79 into openframeworks:master Nov 9, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant