Skip to content

Drop Pydantic v1#93

Open
mattwthompson wants to merge 9 commits into
mainfrom
no-pydantic-v1
Open

Drop Pydantic v1#93
mattwthompson wants to merge 9 commits into
mainfrom
no-pydantic-v1

Conversation

@mattwthompson
Copy link
Copy Markdown
Member

@mattwthompson mattwthompson commented May 27, 2026

Description

Fixes #91

Status

  • Ready to go

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.32%. Comparing base (f9fc1f3) to head (9616143).

Files with missing lines Patch % Lines
descent/train.py 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   97.66%   99.32%   +1.66%     
==========================================
  Files          11       11              
  Lines        1071     1041      -30     
==========================================
- Hits         1046     1034      -12     
+ Misses         25        7      -18     
Flag Coverage Δ
unittests 99.32% <85.71%> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattwthompson mattwthompson marked this pull request as ready for review June 3, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove pydantic v1 support

1 participant