fix: stop favicon requests for private chat-link hosts - #245
Open
leoisadev1 wants to merge 1 commit into
Open
Conversation
Chat markdown and mobile feed links asked Google for a favicon of every host, including loopback, RFC1918, Tailscale, and .local names. Shared classification now refuses those hosts so the globe fallback is used instead. Adapted from pingdotgg#5838.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummarySummary
T-Rex validation blocked
Confidence Score: 5/5Safe to merge: no actionable defects were established. The final finding set is empty. Rendered markdown-link checks confirmed safe favicon behavior for private and public hosts. Files Needing Attention: No files require follow-up changes.
What T-Rex did
Reviews (1): Last reviewed commit: "fix: stop favicon requests for private c..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Private, reserved, Tailscale, and special-purpose hosts no longer get a Google favicon request from chat markdown or the mobile feed. The host classifier lives in
@t3tools/sharedso web preview tabs and chat links use the same rule. Public links still show the favicon.Why
A link to
http://192.168.1.10orhttp://localhost:3000was leaking that hostname to a public favicon provider.Adapted from pingdotgg/t3code#5838.
UI Changes
Private-host links in bot/group markdown use the globe fallback. Public hosts are unchanged.
Checklist
Verification
vp test run packages/shared/src/favicon.test.ts packages/shared/src/hostClassification.test.ts apps/web/src/browser/browserTargetResolver.test.ts(53 tests)Implemented and verified by Grok 4.6 High in Grok Build via Orca.