Draft
Conversation
Pull Request Test Coverage Report for Build 20999685087Details
💛 - Coveralls |
dplore
reviewed
Jan 14, 2026
Comment on lines
+343
to
+347
| - In a modular chassis, the device MUST populate `states` with | ||
| `CONTROL_CARD_STATUS_INITIALIZED` for two control cards. For example, | ||
| a `BOOTSTRAP_STATUS_SUCCESS` report for a modular chassis with one | ||
| state set to `CONTROL_CARD_STATUS_INITIALIZED` and one state set to | ||
| `CONTROL_CARD_STATUS_NOT_INITIALIZED` will be ignored by bootz-server. |
Member
There was a problem hiding this comment.
Suggested change
| - In a modular chassis, the device MUST populate `states` with | |
| `CONTROL_CARD_STATUS_INITIALIZED` for two control cards. For example, | |
| a `BOOTSTRAP_STATUS_SUCCESS` report for a modular chassis with one | |
| state set to `CONTROL_CARD_STATUS_INITIALIZED` and one state set to | |
| `CONTROL_CARD_STATUS_NOT_INITIALIZED` will be ignored by bootz-server. | |
| - In a modular chassis, the device MUST populate `states` with | |
| `CONTROL_CARD_STATUS_INITIALIZED` for each `CONTROLLER_CARD` present in the chassis. | |
| For example, a `BOOTSTRAP_STATUS_SUCCESS` report from a modular chassis containing two | |
| `CONTROLLER_CARD` components must not set one `CONTROLLER_CARD` | |
| stat to `CONTROL_CARD_STATUS_INITIALIZED` and the second `CONTROLLER_CARD` state to | |
| `CONTROL_CARD_STATUS_NOT_INITIALIZED`. Such a status will be treated as invalid by a bootz-server. |
Member
There was a problem hiding this comment.
suggested this because it's possible that a modular chassis could contain only one CONTROLLER_CARD component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Bootz readme to clarify the expected behavior for reporting status on modular devices. It makes it clear that devices should report both control cards as initialized for Bootz to complete.