Use favorites from graph api#2171
Conversation
pascalwengerter
force-pushed
the
favorites-graph-api
branch
3 times, most recently
from
c90aca7 to
82e3529
Compare
|
@pascalwengerter started the ci. Type check and linter are complaining |
Thx, will rebase & address |
pascalwengerter
force-pushed
the
favorites-graph-api
branch
from
82e3529 to
a4cfb4a
Compare
|
@pascalwengerter works very good at first glance! But there is something off with the search, every item is marked as favorite even if they ain't marked as such. 
can you also check if its possible to add project spaces as favorites ? I am not sure if there is a backend limitation, but would be great. |
|
I had a chat with the team. Can you please set the fill type to line in the status indicators, so it machtes the other ones and looks a little more subtle ? 🙏 |
|
Thx for the feedback, will investigate (& adapt the icon). I'm kinda surprised there's no test changes needed/expected failures to update? |
Same, I was expecting there were some disabled e2e tests, but couldn't find any |
| return false | ||
| } | ||
| if (resources.length !== 1) { | ||
| if (resources.length === 0) { |
There was a problem hiding this comment.
To me, it looks like you are trying to make these batch actions compatible, but I can't spot any Batch Action button in the UI
There was a problem hiding this comment.
I also don't know if we want this, spotting @kulmann
| icon: 'star', | ||
| category: 'system', | ||
| type: 'resource-favorite', | ||
| fillType: 'fill' |
There was a problem hiding this comment.
| fillType: 'fill' | |
| fillType: 'line' |
| }, | ||
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=22" |
|
The reason why the search is showing false positive starred items is in the check should be changed to Unfortunately, the search is not yet compatible with favorites yet :sigh: |
|
@pascalwengerter I am baffled. I checked if we can add spaces to favorites and it's supported by the backend. You can add it to space actions if you want to, or I'll do it in a follow-up 👍 |
2 participants
Related Issue
Types of changes