Skip to content

Improve acl tab performance for systems with many roles #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arnei merged 1 commit into from
Apr 29, 2026
Merged

Improve acl tab performance for systems with many roles #1589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState, useEffect } from "react";
import React, { useState, useEffect, useMemo } from "react";
import RenderMultiField from "../wizard/RenderMultiField";
import {
Acl,
Expand Down Expand Up @@ -434,6 +434,12 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

const dropdownOptions = useMemo(() => {
return roles.length > 0
? formatAclRolesForDropdown(rolesFilteredbyPolicies)
: [];
}, [roles, rolesFilteredbyPolicies]);

const createPolicy = (role: string, withUser: boolean): TransformedAcl => {
const user = withUser ? { username: "", name: "", email: "" } : undefined;

Expand Down Expand Up @@ -537,11 +543,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
<DropDown
value={policy.role}
text={createPolicyLabel(policy)}
options={
roles.length > 0
? formatAclRolesForDropdown(rolesFilteredbyPolicies)
: []
}
options={dropdownOptions}
required={true}
creatable={true}
handleChange={element => {
Expand Down
Loading