Retain issue roots in explicit workspaceWrite policies#58
Open
danielmcauley wants to merge 3 commits into
Open
Retain issue roots in explicit workspaceWrite policies#58danielmcauley wants to merge 3 commits into
danielmcauley wants to merge 3 commits into
Conversation
|
I hit this issue as well and an agent made a similar fix |
Jocelynq769
approved these changes
Apr 29, 2026
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
chihsuan
referenced
this pull request
in Automattic/symphony
May 15, 2026
RSM-3010 Guard Codex action approvals
|
BLOCKED-OPERATOR: clean MERGEABLE PR with green checks and approvals, but an active human review request remains for |
This was referenced May 20, 2026
Closed
Closed
corylanou
referenced
this pull request
in digitaldrywood/symphony-elixir
May 21, 2026
#### Context Fixes #23. Upstream #58 keeps issue workspaces writable when explicit workspaceWrite roots add worktree metadata paths. #### TL;DR *Retain the issue workspace in runtime workspaceWrite policies.* #### Summary - Prepend the current issue workspace to explicit workspaceWrite writableRoots at runtime. - Preserve non-workspaceWrite policies and non-runtime explicit config behavior. - Document the upstream adoption and fork changelog origin. - Stabilize retry-delay assertions that failed under CI scheduler load. #### Alternatives - Direct cherry-pick was checked, but the first upstream commit conflicts in fork-shifted docs. - Leaving explicit roots unchanged keeps linked-worktree git metadata fragile. #### Test Plan - [x] `make -C elixir all` - [x] `cd elixir && mix test test/symphony_elixir/app_server_test.exs test/symphony_elixir/workspace_and_config_test.exs test/symphony_elixir/core_test.exs`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Ensure explicit
workspaceWritesandbox policies keep the current issue workspace writable while still allowing extra writable roots like linked-worktree.gitmetadata.TL;DR
Keep the issue workspace in explicit
workspaceWriteroots and update the launcher follow-up contract.Summary
workspaceWritepolicies at runtimeworkspaceWritesandbox policies unchangedAlternatives
cwdbeing writable implicitly, but current runtime/tests model explicitwritableRootsas authoritativeTest Plan
make -C elixir allcd /Users/dtm/code/symphony/elixir && mise exec -- mix test test/symphony_elixir/app_server_test.exs test/symphony_elixir/workspace_and_config_test.exs test/symphony_elixir/core_test.exscd /Users/dtm/code/symphony/elixir && mise exec -- mix specs.check