Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public FlagdProvider(final FlagdOptions options) {
}
hooks.add(new SyncMetadataHook(this::getEnrichedContext));
contextEnricher = options.getContextEnricher();
errorExecutor = Executors.newSingleThreadScheduledExecutor();
errorExecutor = Executors.newSingleThreadScheduledExecutor(new FlagdThreadFactory("flagd-provider-thread"));
gracePeriod = options.getRetryGracePeriod();
deadline = options.getDeadline();
}
Expand All @@ -105,7 +105,7 @@ public FlagdProvider(final FlagdOptions options) {
deadline = Config.DEFAULT_DEADLINE;
gracePeriod = Config.DEFAULT_STREAM_RETRY_GRACE_PERIOD;
hooks.add(new SyncMetadataHook(this::getEnrichedContext));
errorExecutor = Executors.newSingleThreadScheduledExecutor();
errorExecutor = Executors.newSingleThreadScheduledExecutor(new FlagdThreadFactory("flagd-provider-thread"));
if (initialized) {
this.syncResources.initialize();
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package dev.openfeature.contrib.providers.flagd;

import java.util.Objects;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.atomic.AtomicInteger;

/**
* Thread factory for the Flagd provider to allow named daemon threads to be created.
*/
class FlagdThreadFactory implements ThreadFactory {

private final AtomicInteger counter = new AtomicInteger();
private final String namePrefix;

/**
* {@link FlagdThreadFactory}'s constructor.
*
* @param namePrefix Prefix used for setting the new thread's name.
*/
FlagdThreadFactory(String namePrefix) {
this.namePrefix = Objects.requireNonNull(namePrefix, "namePrefix must not be null");
}

@Override
public Thread newThread(Runnable runnable) {
final Thread thread = new Thread(runnable);
thread.setDaemon(true);
thread.setName(namePrefix + "-" + counter.incrementAndGet());
return thread;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package dev.openfeature.contrib.providers.flagd;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertThrows;

import org.junit.jupiter.api.Test;

class FlagdThreadFactoryTest {

private static final String THREAD_NAME = "testthread";
private final Runnable runnable = () -> {};

@Test
void verifyThreadFactoryThrowsNullPointerExceptionWhenNamePrefixIsNull() {

// Then
var exception = assertThrows(NullPointerException.class, () -> {
// When
new FlagdThreadFactory(null);
});
assertThat(exception.toString()).contains("namePrefix must not be null");
}

@Test
void verifyNewThreadHasNamePrefix() {

var flagdThreadFactory = new FlagdThreadFactory(THREAD_NAME);
var thread = flagdThreadFactory.newThread(runnable);

assertThat(thread.getName()).isEqualTo(THREAD_NAME + "-1");
assertThat(thread.isDaemon()).isTrue();
}

@Test
void verifyNewThreadHasNamePrefixWithIncrement() {

var flagdThreadFactory = new FlagdThreadFactory(THREAD_NAME);
var threadOne = flagdThreadFactory.newThread(runnable);
var threadTwo = flagdThreadFactory.newThread(runnable);

assertThat(threadOne.getName()).isEqualTo(THREAD_NAME + "-1");
assertThat(threadOne.isDaemon()).isTrue();
assertThat(threadTwo.getName()).isEqualTo(THREAD_NAME + "-2");
assertThat(threadTwo.isDaemon()).isTrue();
}
}