Skip to content

test: drop assertions on removed output, and one on a mocked call - #61

Merged
vite-hub[bot] merged 2 commits into
mainfrom
test/prune-r6
Nov 18, 2026
Merged

vite-hub[bot] merged 2 commits into
mainfrom
test/prune-r6

Conversation

@onmax

@onmax onmax commented Nov 18, 2026

Copy link
Copy Markdown
Owner

28 assertions across the generation and rendering tests checked that output removed months ago stays gone. They covered headings like ## Precedence and ## Activation Flow, the GitHub-resolved and `unknown` labels, and the old references/index.md, references/nuxt/index.md and manifest.json files. No code in src/, shared/, docs/, scripts/, nuxt-best-practices/ or the README writes any of them now, so these checks can't fail. This PR deletes them.

One more line in module-setup.test.ts checked that the mocked resolveTargets isn't called outside nuxt prepare. That function only reads which agents are installed. Calling it before the prepare check changes nothing a user sees, but it turned the test red. The same test already goes red when the module does run outside prepare, because nuxt.hook gets called.

Test Kind Proof Action
core-content.test.ts › "omits the monorepo scope section for standalone apps": ## Activation Flow, ## High-Frequency Nuxt Decisions, ## Precedence, ## Before Completion, ## Vue guidance, ## All Nuxt packs, ## Primary Packs, references/nuxt/index.md tombstone Removed in 0d88c2b (#10), 75fb341 and 173f8a8 (#27). rg finds no source left. lines deleted
core-content.test.ts › "layers module-author guidance…": the three ## Module author… headings tombstone Removed in 0d88c2b (#10). No source left. lines deleted
core-content.test.ts › "keeps the root module section compact…": GitHub-resolved, `unknown` tombstone The label is gone, and the trust level is now 'official' | 'community'. lines deleted
core-generation, monorepo-generation, module-author-generation, modules-generation: ## Vue guidance, ## Precedence, the three module-author headings, and references/index.md, references/nuxt/index.md and manifest.json not existing tombstone Index files removed in 75fb341 and 173f8a8 (#27), manifest.json in 7e6718a (#34). No source writes them. lines deleted
docs-playground.test.ts › "builds metadata-routed preview files" and remote-resolver.test.ts metadata-router case: This skill was generated from package metadata, references/index.md tombstone The sentence went in 8e7ccbc. The router now says "This module router was generated…", which nothing asserts against. lines deleted
module-setup.test.ts › "does nothing outside nuxt prepare": mockResolveTargets not called change detector Moving resolveTargets() above the _prepare check: old copy red, new copy green. Dropping the _prepare check: new copy red. line deleted

Tests: 125 before, 125 after, all passing. Only assertion lines were cut. Run with node_modules/.bin on PATH as pnpm test sets it, since the generation tests call pnpm exec nuxt prepare in the fixtures.

Kept on purpose:

  • # Nuxt Skill Wrapper and .nuxt/skill-hub in core-generation.test.ts: the generator still finds and replaces what older versions left there.
  • ## Monorepo scope, the gated packs, ### Official upstream skills, ### Resolved module skills and "label":"modules": all still rendered under other options or in the module index.
  • Fetch counts in remote-fetch.test.ts and remote-resolver.test.ts, and prompt counts in install.test.ts: the caching, the skipped network calls and the prompts are the behavior.

Not fixed here: in two of three full runs on this branch, one generation test (core-generation once, modules-generation once) failed inside nuxt prepare with an ENOENT in node_modules/.cache/nuxt-skill-hub. Each passed alone, and the third full run passed 125/125. It looks like a race on the shared cache, and I didn't dig into it.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nuxt-skill-hub Ready Ready Preview Nov 18, 2026 9:36am UTC

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-18T09:35:55.541389Z
We couldn’t complete this review. Comment @codex review to try again.
9c9343c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@pkg-pr-new

pkg-pr-new Bot commented Nov 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nuxt-skill-hub@61

commit: 9c9343c

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: Sound — the PR removes checks for retired output and an internal lookup while keeping assertions for the current output and the nuxt prepare boundary.

Reviewed changes — I found no P0 or P1 defects. pnpm test passed all 125 tests and the package check.

  • Router and generation coverage: The tests still check current routing, gated packs, monorepo scope, and legacy wrapper replacement.
  • Metadata fallback coverage: The playground and remote resolver tests still verify rendered links, and the resolver test still checks that the metadata fallback is selected.
  • Module setup coverage: The non-prepare test still checks that no generation hook is registered and no warning is logged.

Pullfrog  | View workflow run | Using gpt-6.2-sol(high) | 𝕏

@vite-hub
vite-hub Bot merged commit 9328d4b into main Nov 18, 2026
7 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 18, 2026
@vite-hub

vite-hub Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor
Session Status Started Duration
Pending Completed Not started —

Latest result

Pull request merged.

Final answers

Session

Pull request merged.

This branch was successfully deployed

1 active deployment
Preview — 9c9343c0 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant