Repository navigation
test: drop assertions on removed output, and one on a mocked call - #61
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
commit: |
There was a problem hiding this comment.
✅ No new issues found.
Approach: Sound — the PR removes checks for retired output and an internal lookup while keeping assertions for the current output and the nuxt prepare boundary.
Reviewed changes — I found no P0 or P1 defects. pnpm test passed all 125 tests and the package check.
- Router and generation coverage: The tests still check current routing, gated packs, monorepo scope, and legacy wrapper replacement.
- Metadata fallback coverage: The playground and remote resolver tests still verify rendered links, and the resolver test still checks that the metadata fallback is selected.
- Module setup coverage: The non-prepare test still checks that no generation hook is registered and no warning is logged.
gpt-6.2-sol(high) | 𝕏
Latest result Pull request merged. Final answersSession Pull request merged. |

28 assertions across the generation and rendering tests checked that output removed months ago stays gone. They covered headings like
## Precedenceand## Activation Flow, theGitHub-resolvedand`unknown`labels, and the oldreferences/index.md,references/nuxt/index.mdandmanifest.jsonfiles. No code insrc/,shared/,docs/,scripts/,nuxt-best-practices/or the README writes any of them now, so these checks can't fail. This PR deletes them.One more line in
module-setup.test.tschecked that the mockedresolveTargetsisn't called outsidenuxt prepare. That function only reads which agents are installed. Calling it before the prepare check changes nothing a user sees, but it turned the test red. The same test already goes red when the module does run outside prepare, becausenuxt.hookgets called.core-content.test.ts› "omits the monorepo scope section for standalone apps":## Activation Flow,## High-Frequency Nuxt Decisions,## Precedence,## Before Completion,## Vue guidance,## All Nuxt packs,## Primary Packs,references/nuxt/index.mdrgfinds no source left.core-content.test.ts› "layers module-author guidance…": the three## Module author…headingscore-content.test.ts› "keeps the root module section compact…":GitHub-resolved,`unknown`'official' | 'community'.core-generation,monorepo-generation,module-author-generation,modules-generation:## Vue guidance,## Precedence, the three module-author headings, andreferences/index.md,references/nuxt/index.mdandmanifest.jsonnot existingmanifest.jsonin 7e6718a (#34). No source writes them.docs-playground.test.ts› "builds metadata-routed preview files" andremote-resolver.test.tsmetadata-router case:This skill was generated from package metadata,references/index.mdmodule-setup.test.ts› "does nothing outside nuxt prepare":mockResolveTargetsnot calledresolveTargets()above the_preparecheck: old copy red, new copy green. Dropping the_preparecheck: new copy red.Tests: 125 before, 125 after, all passing. Only assertion lines were cut. Run with
node_modules/.binonPATHaspnpm testsets it, since the generation tests callpnpm exec nuxt preparein the fixtures.Kept on purpose:
# Nuxt Skill Wrapperand.nuxt/skill-hubincore-generation.test.ts: the generator still finds and replaces what older versions left there.## Monorepo scope, the gated packs,### Official upstream skills,### Resolved module skillsand"label":"modules": all still rendered under other options or in the module index.remote-fetch.test.tsandremote-resolver.test.ts, and prompt counts ininstall.test.ts: the caching, the skipped network calls and the prompts are the behavior.Not fixed here: in two of three full runs on this branch, one generation test (
core-generationonce,modules-generationonce) failed insidenuxt preparewith anENOENTinnode_modules/.cache/nuxt-skill-hub. Each passed alone, and the third full run passed 125/125. It looks like a race on the shared cache, and I didn't dig into it.