fix: harden supervisor recovery and stuck scan#207
Open
liobrasil wants to merge 3 commits intoholyfuchs/supervisor-fixfrom
Open
fix: harden supervisor recovery and stuck scan#207liobrasil wants to merge 3 commits intoholyfuchs/supervisor-fixfrom
liobrasil wants to merge 3 commits intoholyfuchs/supervisor-fixfrom
Conversation
nvdtf
requested changes
Mar 13, 2026
| return true | ||
| } | ||
|
|
||
| if status == FlowTransactionScheduler.Status.Executed |
Member
There was a problem hiding this comment.
This is the same issue we faced in onflow/FlowYieldVaultsEVM#70
The problem with the fix is that if the transaction panics, lastRebalanceTimestamp is not updated. This makes the rebalancer permanantely stuck because it's Executed and the lastRebalanceTimestamp was never updated.
You might want to consider a grace period based fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification