Repository navigation
client: drop RequestError from generate/chat docstrings - #790
Open
suhailult777 wants to merge 1 commit into
Open
suhailult777 wants to merge 1 commit into
suhailult777 wants to merge 1 commit into
Conversation
The four generate/chat docstrings (sync and async) said a missing model raises RequestError, but nothing in the package raises it. An empty model is sent to the server, which answers 400, and the client raises ResponseError, which the docstrings already document. Fixes ollama#783
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #783
The
generateandchatdocstrings (sync and async) said a missing model raisesRequestError, but nothing in the package raises it. An empty model is sent to the server, which returns 400, and the client raisesResponseError, which is already documented.This removes the incorrect line from the four docstrings. No behavior change. (If you prefer making
RequestErrorreal instead, I can switch to that with a test.)Tests:
pytest tests117 passed; ruff clean.I used AI assistance and reviewed and tested every line.