[FIX] booking_channex: fix model type in server actions#4
Open
abdrahmanrashed wants to merge 137 commits intosaas-19.1-booking-channex-setting-chgafrom
Open
[FIX] booking_channex: fix model type in server actions#4abdrahmanrashed wants to merge 137 commits intosaas-19.1-booking-channex-setting-chgafrom
abdrahmanrashed wants to merge 137 commits intosaas-19.1-booking-channex-setting-chgafrom
Conversation
Same as excise management features, deposit management is useful in several industries. It therefore makes sense to package it in a dedicated submodule. This sets a clear and meaningful distinction between excise, deposit and industry-related features. It also reduces the duplicated records in industry modules by relying on the new deposit_management module. task-5062926 closes odoo#1462 X-original-commit: 04e7943 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
Before this commit, it was impossible to create a new contact, since the on_change on the ID scan was triggered for no reason. This commit adds a filter_domain so that the automation is only triggered if the ID scan is updated. This also fix the linked server action, which was wrongly using record instead of partner in the loop. Task-5440779 closes odoo#1470 Forward-port-of: odoo#1467 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
- Removed all `product.template.attribute.value` records as they are automatically created on `product.template.attribute.line` creation and can no longer be overridden due to new key uniqueness contraint emerging from `product_template_attribute_excluded_value_ids_rel`: odoo/odoo#220378 - Replaced `company_type` and `is_company` fields with 'vat` fields since company type is now computed: odoo/odoo#211043 - Removed `appointment_progress_bar` and `appointment_info` header as they are removed from standard: odoo/enterprise#101785 - Updated restaurant records to match new customization options: https://github.com/odoo/odoo/pull/239681/files - Additional minor view fixes to match standard view modifications. task-5417814 closes odoo#1457 Signed-off-by: Pratima Gupta (pgu) <pgu@odoo.com>
We updated the PO files by taking the version from 19.0 and `msgmerge` them with the latest POT file. closes odoo#1460 Signed-off-by: Dylan Kiss (dyki) <dyki@odoo.com>
- Removing `version: 1.0` since it is now implicitly set as default: odoo/odoo@7176195 Part-of: odoo#1477 Signed-off-by: Abdelrahman Rashed (aras) <aras@odoo.com>
- Removed the remaining `product.templated.attribute.value` models that weren't removed in: odoo#1473 - Modified `real_estate` view according to changes in: odoo/odoo@6ffc28f - Modified `real_estate` website template according to changes in: odoo/odoo@f4aa56f closes odoo#1477 Signed-off-by: Abdelrahman Rashed (aras) <aras@odoo.com>
…eference Fixes the ValueError when duplicating analytical accounts after the analytic_plan_properties record has been deleted. The x_is_property computed field was failing with: `ValueError: External ID not found in the system: industry_real_estate.analytic_plan_properties` **Changes:** - Added `raise_if_not_found=False` parameter to `env.ref()` call - Updated field compute logic to handle missing reference gracefully - Bumped module version to 1.1 closes odoo#1443 closes odoo#1485 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
This commit fixes industries that call _create_journal_and_payment_methods now that pos_online_payment adds default demo data odoo/odoo@68fc7e8 Removes the call and replace `<field name="payment_method_ids"/>`'s eval with `[Command.link(ref('id_of_payment_method'))]` closes odoo#1448 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
In order to automate the export of POT files in industry modules, we add a test that exports the source terms for every installed industry module and saves it to the appropriate location. This can be used by runbot and our sync module to automate the process. closes odoo#1500 X-original-commit: 4b008c8 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com> Signed-off-by: Dylan Kiss (dyki) <dyki@odoo.com>
It appears that we expose all the complexity of the setup of product planning shifts to our users while we may be able to hide part of the complexity for simpler setup of their stay offers and associated resources. In this commit, we aim to: - Simplifying the product form when a stay offer. - Using consistent and simpler naming. - Automate planning role creation/deletion to bind the stay offers to resources to simplify the experience of users. task-5367647 closes odoo#1491 X-original-commit: 7df848e Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com> Signed-off-by: Abdelrahman Rashed (aras) <aras@odoo.com>
Before this commit the maintenance contract logic relied on a hard-coded product ID. As a result, it only worked when that specific maintenance product was selected. Creating a new maintenance product with the same configuration caused the maintenance contract flow to fail. After this commit it removes the static dependency and dynamically identifies the maintenance product using the `x_is_maintenance` ensuring the feature works correctly for any properly configured maintenance product. Task-5468757 closes odoo#1507 X-original-commit: d1777f8 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com> Signed-off-by: Dhrumil Shah (dhrs) <dhrs@odoo.com>
Before this commit the `product_barcodelookup` product attribute was unlinked, which caused errors during the installation of the Hotel industry. After this commit archives the attribute instead of deleting it, preventing installation issues Ticket-5472846 closes odoo#1510 X-original-commit: 18fa64a Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com> Signed-off-by: Dhrumil Shah (dhrs) <dhrs@odoo.com>
This commit adds an extended industry module for construction with: - 'Show Line Numbering': On sale orders and invoices, modify views to make the sequence numbers of the lines visible. - 'Progress Management': In project, handle the SOL progress to easily invoice customers (added in PR:1275). Task-5135963 Part-of: odoo#1502 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
This commit moves the chatter down in order to display the full width of the Sales Order Lines in the progress view. task-5238284 closes odoo#1502 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
In this commit we have - Rename attachment in the Driving School industry - Add missing pictures in appointment of the Sports Club industry Task-5449731 closes odoo#1522 X-original-commit: 7faaea6 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com> Signed-off-by: Dhrumil Shah (dhrs) <dhrs@odoo.com>
Before this commit, this test was relying on the state of the module website_sale, but with the new runbot configuration (installing more apps than what is in the dependencies), this test was wrong. This commit changes the behaviour to rely on the dependency tree of the module instead of the state. closes odoo#1531 X-original-commit: c4f6467 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
We're adding new PO files for the following languages: ar, az, bg, bs, ca, cs, da, de, el, es, es_419, et, fa, fi, fr, he, hi, hr, hu, id, it, ja, kab, ko, ku, lt, lv, mn, my, nb, nl, pl, pt, pt_BR, ro, ru, sk, sl, sr@latin, sv, th, tr, uk, vi, zh_CN, zh_TW
Add the house keeping feature to the booking_engine module, with its own setting so it can be (de)activated. It is designed to allow the management of the cleaning and preparation of each room. This provides a new board summarizing where house keeping stands for each room and a task list automatically populated based on ongoing stays. TASK-5219678 closes odoo#1536 X-original-commit: 1e9aeb4 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com> Signed-off-by: François Vasamillet (frva) <frva@odoo.com>
This commits make the city tax in booking engine optional, put behind a boolean on each product. When it is not active, the popup will not appear to simplify the flow of the users who don't use it. TASK-5419996 closes odoo#1549 X-original-commit: ba27c60 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com> Signed-off-by: François Vasamillet (frva) <frva@odoo.com>
A recent heavy refactor in website_sale removed multiple product templates and consolidated them into a single, class-based template. Because of this change, several Industry websites were still referencing legacy templates, resulting in a “Missing record: Template not found” warning on the website. This commit updates the affected Industry websites to align with the new class-based design approach, ensuring all templates render correctly and the warning is no longer displayed. Task-5419879 COM PR - odoo/odoo#214744 closes odoo#1551 X-original-commit: 877ee72 Signed-off-by: Dhrumil Shah (dhrs) <dhrs@odoo.com>
Part-of: odoo#1776 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
Part-of: odoo#1776 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
closes odoo#1776 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
The wellness practitioners industry relied on Studio only to send a simple automated email. This dependency was too costly for the value it brought to the customer. Removed Studio from the module dependencies and deleted the related automation. task - 5948518 closes odoo#1763 X-original-commit: 92b79d0 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com> Signed-off-by: Chirag Tribhovanbhai Gami (chga) <chga@odoo.com>
Validates: - Sale order line quantity updated from maintained serials via automation - Sale order serials aggregated from order lines - FSM task inherits serials on creation - FSM task serials updated on delivery validation - Duplicate device serials blocked by server action - New device creation triggers outgoing delivery - Lot sale order count computed from related sale orders - Lot project task count computed from related FSM tasks - Lot delivery date computed from latest outgoing picking - Lot maintenance sale orders aggregated from SO lines - Lot maintenance state correctly resolved from deliveries and active subscriptions Task- 5122516 closes odoo#1778 X-original-commit: f0a8cbb Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com> Signed-off-by: Chirag Tribhovanbhai Gami (chga) <chga@odoo.com>
The issue occurred because x_unit_id is a non-stored related field (x_product_id.uom_id). When a product was created on the fly, the related uom_id value was not yet available, which resulted in a null value. To resolve this, a new field `x_unit_custom_id` has been introduced. This field is displayed conditionally when the product is being created dynamically and is used instead of the related field to ensure a valid UoM is assigned. The product creation logic has been updated to assign x_unit_custom_id instead of x_unit_id, preventing the constraint error. Fixed duplication issue in `server_action_create_or_modify_wi_on_sol`: now writes back `x_sale_order_line_id` immediately after creating a new SOL. This ensures subsequent edits update the existing SOL instead of creating duplicates Task-5097492 closes odoo#1787 X-original-commit: e3a2f14 Signed-off-by: Dhrumil Shah (dhrs) <dhrs@odoo.com>
closes odoo#1792 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
This commit adds an automation that automatically settles the POS orders (if any) of a customer when any invoice is created for them. task-5929043 closes odoo#1715 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com> Signed-off-by: Tristan Cazier (trcaz) <trcaz@odoo.com>
If a slot is not linked to a sale.order.line, the automated action to fix the slot time should not be triggered. opw-6000739 closes odoo#1793 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
closes odoo#1802 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
The `trans_export` function was changed to require an environment instead of a cursor as its last argument. This made it so the test failed to export the POT files. We update the function call here to use the correct argument. closes odoo#1810 X-original-commit: 7510c15 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
Before this commit, the test to automatically export pot files was looping over industry modules. But since saas-18.3, there are technical submodules which are not included in the installed_industries variable. This commit adapts the test to loop over installed_modules, which includes all industry modules and technical modules. closes odoo#1814 X-original-commit: 527dac6 Signed-off-by: Dylan Kiss (dyki) <dyki@odoo.com> Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
In 19.1, standard odoo moved admin employee from data to demo data. Since it is needed it for demo data in industry modules, this commit creates a default admin employee demo data from base.user_admin for all DBs in base_industry_data and makes sure we don't conflict with any existing one. task-5865586 closes odoo#1634 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
We're adding new PO files for the following languages: ar, az, bg, bs, ca, cs, da, de, el, es, es_419, et, fa, fi, fr, he, hi, hr, hu, id, it, ja, kab, ko, ku, lt, lv, mn, my, nb, nl, pl, pt, pt_BR, ro, ru, sk, sl, sr@latin, sv, th, tr, uk, vi, zh_CN, zh_TW
* = ['booking_engine', 'booking_channex'] - Add channel manager setting in booking engine - Install/uninstall booking_channex module via setting - Add API key configuration - Improve channex mapping model and views - Update module dependencies Task : 5913892
frva-odoo
requested changes
Apr 14, 2026
frva-odoo
left a comment
frva-odoo
left a comment
There was a problem hiding this comment.
Good refactoring, I only have a few comments. Great job !
| <field name="name">Channex: Webhook action - manage booking create/change/delete</field> | ||
| <field name="model_id" ref="sale.model_sale_order" /> | ||
| <field name="state">code</field> | ||
| <field name="code"><
abdrahmanrashed
force-pushed
the
saas-19.1-booking-channex-mapping-aras
branch
from
0600e7d to
fb8fb65
Compare
chga-odoo
force-pushed
the
saas-19.1-booking-channex-setting-chga
branch
7 times, most recently
from
2051edf to
0dbfdb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x_model_typevalues in channex server actions to match selection values.task-5913987