Skip to content

frontend: Use same base theme on Win 10/11#13597

Open
Warchamp7 wants to merge 1 commit into
obsproject:masterfrom
Warchamp7:windows-qt-on-win11
Open

frontend: Use same base theme on Win 10/11#13597
Warchamp7 wants to merge 1 commit into
obsproject:masterfrom
Warchamp7:windows-qt-on-win11

Conversation

@Warchamp7

@Warchamp7 Warchamp7 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

Forces Windows 11 to use the windowsvista base theme.

Fixes some weird padding issues on Windows 11 on the current Qt version.
image

Fixes #13598

Motivation and Context

We override pretty much every aspect of the style via our stylesheet so this just ensures Win 10 and Win 11 both start from the same base appearance, instead of the system default Qt style (windowsvista on Win10, windows11 on Win11)

How Has This Been Tested?

Compiled and ran on my Windows 11 laptop. Confirmed that the extra padding in list views is gone.

Also compiled and ran on my Windows 10 machine with the style set to windows11 instead, which caused the excessive padding on my Windows 10 machine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Warchamp7 Warchamp7 added this to the OBS Studio 32.2 milestone Jun 26, 2026
@Warchamp7 Warchamp7 added platform/windows Categorizes issue or PR as affecting Windows specifically area/ui-ux Anything to do with changes or additions to UI/UX elements. release-note/fix labels Jun 26, 2026
@RytoEX

RytoEX commented Jun 26, 2026

Copy link
Copy Markdown
Member

This seems a bit of a kludge. The windowsvista style is less maintained than the windows11 from a glance at the commit history, and there are some behavior differences between the two (progress bar text rendering, I think). I would not be surprised if some day Qt removes the windowsvista style, so we should report this as a QTBUG.

I would be curious if this is still an issue: https://qt-project.atlassian.net/browse/QTBUG-142408

@Warchamp7

Copy link
Copy Markdown
Member Author

This seems a bit of a kludge. The windowsvista style is less maintained than the windows11 from a glance at the commit history, and there are some behavior differences between the two (progress bar text rendering, I think). I would not be surprised if some day Qt removes the windowsvista style, so we should report this as a QTBUG.

I would be curious if this is still an issue: https://qt-project.atlassian.net/browse/QTBUG-142408

The windows style which is based off windows 95 still exists and would work just as well too. I'm not sure why you'd expect the vista theme to have a more active commit history than the windows11 theme, which is clearly still a work in progress :P

@RytoEX RytoEX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I would personally prefer we use the more modern windows11 style as our base style, @Warchamp7 maintains the UI and themes, and I don't want to make that more difficult.

At some point in the future, I would like to revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui-ux Anything to do with changes or additions to UI/UX elements. platform/windows Categorizes issue or PR as affecting Windows specifically release-note/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Excessive padding on Windows 11 list views

2 participants