libobs: Only emit core signal handlers for public canvases#13574
Open
tt2468 wants to merge 2 commits into
Open
libobs: Only emit core signal handlers for public canvases#13574tt2468 wants to merge 2 commits into
tt2468 wants to merge 2 commits into
Conversation
Just a nitpick, as `signal_source` is a copy/paste from obs-source
Amends behavior to match other notable object types like sources
6 tasks
derrod
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Amends behavior to match other notable object types like sources. Private canvases should never have their events emitted to the core signal handler.
Motivation and Context
This implicitly fixes an obs-websocket crash that can occur when a private canvas with a NULL name is destroyed. For example, in #12442
How Has This Been Tested?
Compiles
Types of changes
Checklist: