libobs: Prevent loading Mouse1/Mouse2 as hotkeys#13520
Open
KEY-13 wants to merge 1 commit into
Open
Conversation
The frontend already prevents users from setting Mouse1 or Mouse2 as hotkeys via the UI, but if someone manually edits their scene collection JSON file to add these keys, OBS would still load them, causing unexpected behavior. Add a guard in create_binding() to filter out OBS_KEY_MOUSE1 and OBS_KEY_MOUSE2. This placement ensures the protection also covers third-party plugins that call the public API function obs_hotkey_load_bindings(). Closes obsproject#13403
Member
|
Please properly fill out the PR template, ensuring each item is correctly followed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend already prevents users from setting Mouse1 or Mouse2 as hotkeys via the UI, but if someone manually edits their scene collection JSON file to add these keys, OBS would still load them, causing unexpected behavior.
Add a guard in create_binding() to filter out OBS_KEY_MOUSE1 and OBS_KEY_MOUSE2. This placement ensures the protection also covers third-party plugins that call the public API function obs_hotkey_load_bindings().
Closes #13403
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: