vlc-video: Fix 5.1(back) & 7.1 channel ordering#12601
Open
pkviet wants to merge 2 commits into
Open
Conversation
pkviet
added
kind/bug
pkviet
force-pushed
the
vlcfix2
branch
3 times, most recently
from
56181d9 to
adb74ff
Compare
|
I've tested this version and the VLC Video Source seems to work perfectly [with 5.1] — all audio channels are playing in the correct speakers. I'd call this fixed! |
Member
Author
|
Updated to fix 7.1 which was also misordered by vlc source |
|
I think I have this latest version ("OBS 32.0.0-beta2-9-geac8e61ba", right?) and it also works fine with the Fraunhofer 5.1 file. |
pkviet
changed the title
pkviet
force-pushed
the
vlcfix2
branch
2 times, most recently
from
9dee710 to
7d44623
Compare
RytoEX
requested changes
May 7, 2026
pkviet
force-pushed
the
vlcfix2
branch
2 times, most recently
from
f4e7076 to
ae230e9
Compare
RytoEX
requested changes
Jun 23, 2026
This adds a function allowing to set a custom channel matrix, allowing channel rerouting. This is useful when sources provide layouts not supported by obs or to correct incorrect channel assignments. Signed-off-by: pkv <pkv@obsproject.com>
This fixes the 5.1(back) channel order from: FL FR BL BR FC LFE to FL FR FC LFE BL BR. Fixes obsproject#12579. This also fixes the 7.1 channel order from FL FR SL SR BL BR FC LFE to FL FR FC LFE BL BR SL SR Signed-off-by: pkv <pkv@obsproject.com>
RytoEX
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
VLC source misorders 5.1(back) & 7.1 channel order.
It delivers for LC-AAC, HE-AAC, PCM sources for 5.1: FL FR BL BR FC LFE instead of FL FR FC LFE BL BR.
And for 7.1: FL FR SL SR BL BR FC LFE instead of FL FR FC LFE BL BR SL SR
This fixes the issue by calling swresample and providing it with a channel matrix to do an explicit channel swap.
Motivation and Context
Fixes #12579.
How Has This Been Tested?
Used Fraunhoffer 5.1(back) & 7.1 test sources with VLC Source and checked that the ordering is now correct.
Types of changes
Checklist: