frontend: Improve preview source snapping#12298
Conversation
PatTheMav
left a comment
There was a problem hiding this comment.
Functionally this PR is fine, but it seems very brute force and not particularly efficient to me and falls victim to "featuritis", just piling on little features one by one, each doing its own thing in isolation with no regard to other (similar) features and the architecture behind it.
Preview control drawing should be a single process, by a single responsible entity in code that knows about all of its "features" and thus set up a single render pass to draw all the pieces it knows should be visible for any given frame.
a7a004e to
f53cd97
Compare
|
I've added another commit that updates the default snap distance from |
Description
This PR makes a number of changes to source snapping in the preview:
Additionally
obs64_wuvM7eemGG.mp4
Motivation and Context
I want to improve source snapping behaviour and visual feedback
How Has This Been Tested?
Moved a bunch of sources around. Toggled relevant snapping settings on and off to ensure behaviour matched settings.
Types of changes
Checklist: