Skip to content

frontend: Make OBSAbout self contained#12202

Open
cg2121 wants to merge 1 commit into
obsproject:masterfrom
cg2121:obsbasic-defriend-obsabout
Open

frontend: Make OBSAbout self contained#12202
cg2121 wants to merge 1 commit into
obsproject:masterfrom
cg2121:obsbasic-defriend-obsabout

Conversation

@cg2121

@cg2121 cg2121 commented May 24, 2025

Copy link
Copy Markdown
Contributor

Description

This makes it so OBSAbout isn't tangled with OBSBasic.

Motivation and Context

Make frontend less messy

How Has This Been Tested?

Opened about dialog to make sure it still worked

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 added area/ui-ux Anything to do with changes or additions to UI/UX elements. kind/cleanup Non-breaking change which makes code smaller or more readable labels May 24, 2025
@cg2121 cg2121 force-pushed the obsbasic-defriend-obsabout branch 2 times, most recently from a9086a3 to 112b814 Compare May 24, 2025 13:47
@cg2121 cg2121 changed the title UI: Make OBSAbout self contained frontend: Make OBSAbout self contained May 24, 2025
@cg2121 cg2121 force-pushed the obsbasic-defriend-obsabout branch from 112b814 to 5a19707 Compare May 24, 2025 13:55

@PatTheMav PatTheMav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this encapsulates the management (and updating) of the patronJSON entirely into the OBSAbout class? Nice.

Why does it need to include OBSApp though?

@cg2121

cg2121 commented May 24, 2025

Copy link
Copy Markdown
Contributor Author

It is needed for the GetDataFilePath function. OBSApp.hpp was included with OBSBasic.hpp before.

Comment thread frontend/dialogs/OBSAbout.hpp
Comment thread frontend/dialogs/OBSAbout.cpp
@RytoEX

RytoEX commented Dec 18, 2025

Copy link
Copy Markdown
Member

This has a merge conflict. cc @Warchamp7

@RytoEX RytoEX moved this from In Review to Requires Changes in OBS Studio 32.1 PR Considerations Dec 18, 2025
@Warchamp7 Warchamp7 force-pushed the obsbasic-defriend-obsabout branch from 5a19707 to 142353d Compare December 25, 2025 17:14
@Warchamp7

Copy link
Copy Markdown
Member

This has a merge conflict. cc @Warchamp7

Rebased

@Warchamp7

Copy link
Copy Markdown
Member

Now featuring 100% less accidental submodule commits.

Comment thread frontend/dialogs/OBSAbout.cpp Outdated
Comment thread frontend/dialogs/OBSAbout.cpp Outdated
Comment thread frontend/dialogs/OBSAbout.cpp Outdated
@RytoEX

RytoEX commented May 5, 2026

Copy link
Copy Markdown
Member

Might have a conflict with #12934 since that changes some stuff regarding RemoteTextThread.

@Warchamp7 Warchamp7 added this to the OBS Studio 32.2 milestone May 6, 2026
@RytoEX

RytoEX commented May 6, 2026

Copy link
Copy Markdown
Member

Now that #12934 is merged, please resolve merge conflicts and ensure that this still functions as intended after changes to RemoteTextThread.

This makes it so OBSAbout isn't tangled with OBSBasic.
@cg2121 cg2121 force-pushed the obsbasic-defriend-obsabout branch from 8761377 to e55b2ec Compare May 6, 2026 22:46
@cg2121

cg2121 commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

I fixed the merge conflicts and made sure it still works with the changes to the RemoteTextThread.

@PatTheMav PatTheMav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've encountered the issue of the about dialog opening up but the patron list was empty once, but haven't been able to reproduce it yet. In all consecutive attempts it worked as it should, though it's a bit unfortunate that a user can trigger the presentation of the dialog, but then potentially nothing will happen until eventually the remote text thread returns either an error message or the patron list.

IMO the dialog should not appear conditionally (because the user triggered a menu action, so the dialog should appear immediately) and instead should be able to handle an empty patron list gracefully, though that'd be out of scope for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui-ux Anything to do with changes or additions to UI/UX elements. kind/cleanup Non-breaking change which makes code smaller or more readable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants