frontend: Make OBSAbout self contained#12202
Conversation
a9086a3 to
112b814
Compare
112b814 to
5a19707
Compare
PatTheMav
left a comment
There was a problem hiding this comment.
So this encapsulates the management (and updating) of the patronJSON entirely into the OBSAbout class? Nice.
Why does it need to include OBSApp though?
|
It is needed for the GetDataFilePath function. OBSApp.hpp was included with OBSBasic.hpp before. |
|
This has a merge conflict. cc @Warchamp7 |
5a19707 to
142353d
Compare
Rebased |
142353d to
8761377
Compare
|
Now featuring 100% less accidental submodule commits. |
|
Might have a conflict with #12934 since that changes some stuff regarding RemoteTextThread. |
|
Now that #12934 is merged, please resolve merge conflicts and ensure that this still functions as intended after changes to RemoteTextThread. |
This makes it so OBSAbout isn't tangled with OBSBasic.
8761377 to
e55b2ec
Compare
|
I fixed the merge conflicts and made sure it still works with the changes to the RemoteTextThread. |
PatTheMav
left a comment
There was a problem hiding this comment.
I've encountered the issue of the about dialog opening up but the patron list was empty once, but haven't been able to reproduce it yet. In all consecutive attempts it worked as it should, though it's a bit unfortunate that a user can trigger the presentation of the dialog, but then potentially nothing will happen until eventually the remote text thread returns either an error message or the patron list.
IMO the dialog should not appear conditionally (because the user triggered a menu action, so the dialog should appear immediately) and instead should be able to handle an empty patron list gracefully, though that'd be out of scope for this PR.
Description
This makes it so OBSAbout isn't tangled with OBSBasic.
Motivation and Context
Make frontend less messy
How Has This Been Tested?
Opened about dialog to make sure it still worked
Types of changes
Checklist: