fix(dashboard): show ConnectionCard for non-catalog internal projects - #507
Open
santhiprakash wants to merge 1 commit into
Open
fix(dashboard): show ConnectionCard for non-catalog internal projects#507santhiprakash wants to merge 1 commit into
santhiprakash wants to merge 1 commit into
Conversation
The ConnectionCard was only rendered for catalog apps (projectData.isApp), so plain single-app / Compose / monorepo projects had no UI path to create internal connections even though GET /api/projects/:id/app-connection already synthesizes http://<alias>:<port> outputs for them. Now the card mounts for: - catalog apps (their curated URLs + generated keys), or - any other project with a listening runtime that is not cloud-deployed (so static apps and cloud sources, which cannot be linked internally, are still excluded). ConnectionCard already self-hides when the view has no outputs, so projects that produce nothing reachable still render nothing. Closes oblien#504 Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashboard only rendered
<ConnectionCard />whenprojectData.isAppwas true.isAppis only set for projects installed from the app catalog, so plain single-app, raw Compose, and monorepo projects never got the UI path to create internal connections — even though the backend already synthesizeshttp://<alias>:<port>outputs for them viaGET /api/projects/:id/app-connection.This change gates
ConnectionCardon whether the project can actually expose an internal connection:ConnectionCardalready self-hides when the returned view has no outputs, so projects with nothing reachable still render nothing.Fixes #504.
Test plan
bun run lint(tsc --noEmit) inapps/dashboardpasses