Configuration and segfault fixes#2
Open
gfto wants to merge 9 commits intoob-encoder:masterfrom
gfto:stuff
Open
Configuration and segfault fixes#2gfto wants to merge 9 commits intoob-encoder:masterfrom gfto:stuff
gfto wants to merge 9 commits intoob-encoder:masterfrom
gfto:stuff
Conversation
added 9 commits
October 13, 2011 16:36
On Slackware readline library is linked with ncurses and when -lncurses is missing from readline check the check fails.
…rted. This prevents segfault on exit from obecli.
This prevents segfault on exit from obecli.
With this sleep obe segfaults when trying run probe.
gfto
pushed a commit
to gfto/obe-rt
that referenced
this pull request
Oct 29, 2013
Calling pthread_cancel( NULL ) results in the same crash as calling pthread_join( NULL, ... ) This fixes the following: Start obecli. obecli> set input decklink obecli> set input opts card-idx=0 obecli> probe input Probing device: Decklink card 0. Timeout 20 seconds Detected input streams: Input-stream-id: 0 - Video: RAW 720x576i 25/1fps Input-stream-id: 1 - Audio: PCM 16 channels 48kHz Encoder outputs: Output-stream-id: 0 - Input-stream-id: 0 - Video: AVC Output-stream-id: 1 - Input-stream-id: 1 - Audio: RAW - SDI audio pair: 1 obecli> quit closing obe Program received signal SIGSEGV, Segmentation fault. 0x00007ffff6675be1 in pthread_cancel () from /lib64/libpthread.so.0 (gdb) bt #0 0x00007ffff6675be1 in pthread_cancel () from /lib64/libpthread.so.0 ob-encoder#1 0x00000000004483d1 in obe_close (h=0x1417860) at obe.c:1233 ob-encoder#2 0x000000000044433f in stop_encode (command=command@entry=0x0, child=child@entry=0x0) at obecli.c:1353 ob-encoder#3 0x0000000000446d92 in main (argc=<optimized out>, argv=<optimized out>) at obecli.c:1534
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these fixes I can compile obe-rt successfully under Slackware64 and use it to capture and encode video/audio with DeckLink Studio card. The commits are mixed, if you like what they are doing I can rebuild them to be more split by topic.