fix: avoid forcing msgpack support in dev phpfpm pecl install - #185
fix: avoid forcing msgpack support in dev phpfpm pecl install#185carloscolmenarezsmowl wants to merge 1 commit into
Conversation
Piping `yes` to `pecl install redis` answers 'y' to every configure prompt, including "enable msgpack serializer support". Without the msgpack PECL extension installed, the build fails on `Cannot find php_msgpack.h`. Switch to `printf "\n"` so defaults are accepted, matching the pattern already used in docker/kube/Dockerfile.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: https://raw.githubusercontent.com/oat-sa/tao-code-quality/main/coderabbit/php/common/v1/.coderabbit.yaml (via .coderabbit.yaml) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesPECL Extension Installation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Actionable comments posted: 0 |
Summary
yes | pecl install igbinary rediswithprintf "\n" | pecl install igbinary redisindocker/phpfpm/Dockerfile.Piping
yesanswersyto every configure prompt of theredisPECL extension, including "enable msgpack serializer support". Since themsgpackextension is not installed in the image, the build fails looking forphp_msgpack.h. Usingprintf "\n"accepts defaults instead, matching the pattern already used indocker/kube/Dockerfile.Fixes #184
Test plan
docker compose build devkit_lti1p3_phpfpmcompletes successfully.docker compose up -dbrings up all containers anddevkit_lti1p3_phpfpmreportsready to handle connections.Summary by CodeRabbit