Skip to content

fix: avoid forcing msgpack support in dev phpfpm pecl install - #185

Open
carloscolmenarezsmowl wants to merge 1 commit into
oat-sa:masterfrom
carloscolmenarezsmowl:fix/dev-dockerfile-pecl-msgpack
Open

fix: avoid forcing msgpack support in dev phpfpm pecl install#185
carloscolmenarezsmowl wants to merge 1 commit into
oat-sa:masterfrom
carloscolmenarezsmowl:fix/dev-dockerfile-pecl-msgpack

Conversation

@carloscolmenarezsmowl

@carloscolmenarezsmowl carloscolmenarezsmowl commented May 28, 2026

Copy link
Copy Markdown

Summary

  • Replace yes | pecl install igbinary redis with printf "\n" | pecl install igbinary redis in docker/phpfpm/Dockerfile.

Piping yes answers y to every configure prompt of the redis PECL extension, including "enable msgpack serializer support". Since the msgpack extension is not installed in the image, the build fails looking for php_msgpack.h. Using printf "\n" accepts defaults instead, matching the pattern already used in docker/kube/Dockerfile.

Fixes #184

Test plan

  • docker compose build devkit_lti1p3_phpfpm completes successfully.
  • docker compose up -d brings up all containers and devkit_lti1p3_phpfpm reports ready to handle connections.

Summary by CodeRabbit

  • Chores
    • Improved Docker PHP-FPM container build process to handle dependency installation prompts more reliably during image construction.

Review Change Stack

Piping `yes` to `pecl install redis` answers 'y' to every configure
prompt, including "enable msgpack serializer support". Without the
msgpack PECL extension installed, the build fails on
`Cannot find php_msgpack.h`. Switch to `printf "\n"` so defaults are
accepted, matching the pattern already used in docker/kube/Dockerfile.
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: https://raw.githubusercontent.com/oat-sa/tao-code-quality/main/coderabbit/php/common/v1/.coderabbit.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 526e57b7-1464-46c8-bfa3-bdc3477ab8e6

📥 Commits

Reviewing files that changed from the base of the PR and between 2fb6894 and b958bae.

📒 Files selected for processing (1)
  • docker/phpfpm/Dockerfile

📝 Walkthrough

Walkthrough

The docker/phpfpm/Dockerfile PECL installation command is updated to pipe a newline instead of always-yes responses into pecl install igbinary redis. This accepts extension defaults without forcing optional dependency prompts, aligning the development image build pattern with production.

Changes

PECL Extension Installation

Layer / File(s) Summary
Fix interactive prompt handling in PECL installation
docker/phpfpm/Dockerfile
The pecl install command replaces yes | piping with printf "\n" | to accept defaults without forcing optional dependencies like msgpack, resolving configure failures when dependencies are absent.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

⏱️ <10 Min Review

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: replacing yes piping with printf newline to avoid forcing msgpack support in the PECL installation.
Linked Issues check ✅ Passed The code changes directly address issue #184 by replacing yes piping with printf newline, matching the suggested fix and resolving the msgpack configuration failure.
Out of Scope Changes check ✅ Passed The change is limited to the Dockerfile modification specified in the linked issue with no additional unrelated alterations present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev phpfpm image fails to build: yes | pecl install redis forces msgpack support

1 participant